From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] wm8350-regulator: fix wm8350_register_regulator error handling
Date: Mon, 26 Jul 2010 00:07:20 -0700 [thread overview]
Message-ID: <B518CF98-BD06-466C-AD40-BBC4C485C3F4@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1280112118.14256.1.camel@mola> (sfid-20100726_034140_195818_204F7320)
On 25 Jul 2010, at 19:41, Axel Lin <axel.lin@gmail.com> wrote:
> In the case of platform_device_add() fail, we should call
> platform_device_put() instead of platform_device_del()
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/wm8350-regulator.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/wm8350-regulator.c b/drivers/regulator/wm8350-regulator.c
> index 723cd1f..0e6ed7d 100644
> --- a/drivers/regulator/wm8350-regulator.c
> +++ b/drivers/regulator/wm8350-regulator.c
> @@ -1495,7 +1495,7 @@ int wm8350_register_regulator(struct wm8350 *wm8350, int reg,
> if (ret != 0) {
> dev_err(wm8350->dev, "Failed to register regulator %d: %d\n",
> reg, ret);
> - platform_device_del(pdev);
> + platform_device_put(pdev);
> wm8350->pmic.pdev[reg] = NULL;
> }
>
> --
> 1.5.4.3
>
>
>
next prev parent reply other threads:[~2010-07-26 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 2:41 Axel Lin
2010-07-26 7:07 ` Mark Brown [this message]
2010-07-27 10:35 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B518CF98-BD06-466C-AD40-BBC4C485C3F4@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®