From: "Clément Chauplannaz" <chauplac@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
Michal Marek <mmarek@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] scripts/config: use sed's POSIX interface
Date: Fri, 13 Sep 2013 11:54:31 +0200 [thread overview]
Message-ID: <B58F4964-E48A-4D56-ABEE-C8E9514B2651@gmail.com> (raw)
In-Reply-To: <CACRpkdY8nLnH5RG94kXuWBv=qb6osRSvGRODy3ywKDdHSGae5w@mail.gmail.com>
On Sep 13, 2013, at 11:32 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Sep 13, 2013 at 10:38 AM, Clément Chauplannaz
> <chauplac@gmail.com> wrote:
>
>> Thank you for this report. I was able to reproduce this bug and fix it.
>
> Thanks! Tested and works fine.
Glad to read the patch solves your issue. Thanks for the quick feedback!
>
>> My previous commit changed the separator between sed's substitute
>> command and its parameters, from ':' to '/'. The latter conflicted
>> with the slashes found in the value of variable CMDLINE, as provided
>> in your email.
>
> Hm it could actually be useful to be able to have colons in a CMDLINE,
> I wonder if we can think about some better separator ... oh well that
> is another issue, all old scripts work now anyway.
Indeed config script may not work with all possible string values. My first concern for now was to fallback to previous interface. We may look into hardening the script later on.
Best regards,
Clement Chauplannaz
next prev parent reply other threads:[~2013-09-13 9:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 21:17 [pull request] Pull request for branch yem/kconfig-for-next Yann E. MORIN
2013-08-15 21:17 ` [PATCH 1/4] kconfig: switch to "long long" for sanity Yann E. MORIN
2013-08-15 21:17 ` [PATCH 2/4] scripts/config: use sed's POSIX interface Yann E. MORIN
2013-09-12 16:40 ` Linus Walleij
2013-09-13 8:38 ` Clément Chauplannaz
2013-09-13 8:45 ` [PATCH] scripts/config: fix variable substitution command Clement Chauplannaz
2013-09-13 9:29 ` Linus Walleij
2013-09-13 9:32 ` [PATCH 2/4] scripts/config: use sed's POSIX interface Linus Walleij
2013-09-13 9:54 ` Clément Chauplannaz [this message]
2013-09-13 11:00 ` Michal Marek
2013-08-15 21:17 ` [PATCH 3/4] kconfig: silence warning when parsing auto.conf when a symbol has changed type Yann E. MORIN
2013-08-15 21:17 ` [PATCH 4/4] modules: do not depend on kconfig to set 'modules' option to symbol MODULES Yann E. MORIN
2013-08-16 12:48 ` [pull request] Pull request for branch yem/kconfig-for-next Michal Marek
2013-08-16 13:02 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B58F4964-E48A-4D56-ABEE-C8E9514B2651@gmail.com \
--to=chauplac@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®