From: Ed Cashin <ecashin@coraid.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH] aoe: adjust ref of head for compound page tails
Date: Wed, 7 Aug 2013 19:48:15 -0400 [thread overview]
Message-ID: <B5AF5A8D-2849-4027-A524-BA31BBCF8C8F@coraid.com> (raw)
In-Reply-To: <3F0FBDD9-129C-45F4-A20C-3EB2E8EFC9C8@coraid.com>
On Aug 7, 2013, at 7:41 PM, Ed Cashin wrote:
> It sounds like it's wrong to give block pages with a zero count, so why not just have aoe BUG_ON(compound_trans_head(bv->page->_count) == 0) until we're sure nobody does that anymore?
Ugh. I goofed the parens and such. I meant,
BUG_ON(compound_trans_head(bv->bv_page)->_count == 0)
... will catch the cases we think should not be occurring.
> If that idea makes sense to you, I will submit a new patch to follow the one under discussion.
--
Ed Cashin
ecashin@coraid.com
next prev parent reply other threads:[~2013-08-07 23:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 1:29 [PATCH] aoe: respect compound page reference tracking expectations Ed Cashin
2013-08-02 1:29 ` [PATCH] aoe: adjust ref of head for compound page tails Ed Cashin
2013-08-07 20:58 ` Andrew Morton
2013-08-07 21:12 ` Ed Cashin
2013-08-07 21:18 ` Andrew Morton
2013-08-07 21:27 ` Andrew Morton
2013-08-07 23:41 ` Ed Cashin
2013-08-07 23:48 ` Ed Cashin [this message]
2013-08-07 23:51 ` Andrew Morton
2013-08-07 21:00 ` Andrew Morton
2013-08-07 21:21 ` Ed Cashin
2013-08-07 21:26 ` Andrew Morton
2013-08-07 23:27 ` Ed Cashin
2013-08-07 23:35 ` Andrew Morton
2013-08-07 23:54 ` Ed Cashin
2013-08-08 0:05 ` Andrew Morton
2013-08-08 0:50 ` Ed Cashin
2013-08-08 19:56 ` Andrew Morton
2013-08-08 21:02 ` Ed Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B5AF5A8D-2849-4027-A524-BA31BBCF8C8F@coraid.com \
--to=ecashin@coraid.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®