From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA22636A002 for ; Wed, 4 Feb 2026 06:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185221; cv=none; b=UvbZDcCvFYAwjIQfajNdg0lfOrVpMTiL8E8IZRkLIsf2aIXGVxC+tQfXgF4c8YuyRdj5ZLul0TKd/38sZ8o8j1YbSqDxNPtADlo6QMAkN35kAWP2m38I1QmypxfDetBG/wH3QEQfzP6l3gQzDfAbd3kEeMatnE8V2n+wpkR6lP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770185221; c=relaxed/simple; bh=FguD/Jmk4BwTZfFZIdyNc64l/P9T5XMy2I61XbcXxvM=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=Xho/bFpSrOyD21NPqFOdaJEa0/sEhOIsoIioHpVN0/cTILbPD2m8t7W25eJ3M9YoenoFYbFwR49fWki0Fii1FOi2pQBsdQOHApLz0jSloOJFybWquObeeuEnCkYbm5aedQhc4Lq1XkYMIbck2I7LRZJA1WddpxC1UcBdT18k+GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Mg52tzCN; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Mg52tzCN" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770185218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FguD/Jmk4BwTZfFZIdyNc64l/P9T5XMy2I61XbcXxvM=; b=Mg52tzCNcLklqvPmjV6pKIb2fnq8a6CHEYApvj+iYB8x51FSsUIicgNB9B6jpn1332VK/F 9/w3SJLh4UStR8W/nAQco4kYgApMRsvDvvaBd0Z0EJ60iGuQ44Wh7ieBcSQS+IzdGVGm6T 1yi2Dv56D7PPauSEJkAeSCdUP0lZzqU= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\)) Subject: Re: [PATCH v1] hugetlb: simplify remove_inode_hugepages() return type X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20260202233617.2350734-1-jiaqiyan@google.com> Date: Wed, 4 Feb 2026 14:06:14 +0800 Cc: jane.chu@oracle.com, osalvador@suse.de, david@kernel.org, william.roche@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260202233617.2350734-1-jiaqiyan@google.com> To: Jiaqi Yan X-Migadu-Flow: FLOW_OUT > On Feb 3, 2026, at 07:36, Jiaqi Yan wrote: >=20 > When remove_inode_hugepages is introduced in > commit c86272287bc6 ("hugetlb: create remove_inode_single_folio to = remove single file folio") > it used to return a boolean to indicate if it bailed out due to race = with > page faults. However, since the race is already solved by [1], > remove_inode_hugepages() doesn't have any path to return false = anymore. >=20 > Simplify remove_inode_hugepages() return type to void, remove the > unnecessary ret variable, and adjust the call site in > remove_inode_hugepages(). No functional change in this commit. >=20 > [1] = https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@oracle.co= m >=20 > Suggested-by: Jane Chu > Signed-off-by: Jiaqi Yan Reviewed-by: Muchun Song