From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754247AbcI2FSt (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Sep 2016 01:18:49 -0400
Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]:22105 "EHLO
        mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751038AbcI2FSk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Sep 2016 01:18:40 -0400
X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcZa0CjPwrtwsa7s0mYZj78qgNwBSw96A==
X-RZG-CLASS-ID: mo00
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [PATCH 2/3] DT: EVM: add LEDs
From: "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <CAL_Jsq+hVD2TCubk8vGf8cS7dyLQj1o0ChnQ=MobKkV352uCSQ@mail.gmail.com>
Date: Thu, 29 Sep 2016 07:18:23 +0200
Cc: =?utf-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-omap <linux-omap@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        letux-kernel@openphoenux.org
Message-Id: <B8233FFD-C7CE-4F3A-957F-0715BDF02D44@goldelico.com>
References: <cover.1474953969.git.hns@goldelico.com> <d68619a23d642eacf12fd0a3c51f19d006436cbe.1474953969.git.hns@goldelico.com> <CAL_Jsq+hVD2TCubk8vGf8cS7dyLQj1o0ChnQ=MobKkV352uCSQ@mail.gmail.com>
To: Rob Herring <robh+dt@kernel.org>
X-Mailer: Apple Mail (2.3124)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8T5Ix4Y019286


> Am 29.09.2016 um 07:14 schrieb Rob Herring <robh+dt@kernel.org>:
> 
> On Tue, Sep 27, 2016 at 12:26 AM, H. Nikolaus Schaller
> <hns@goldelico.com> wrote:
> 
> The subject gives no indication this is for OMAP. Please follow
> standard patterns.

Already fixed. Please see v2.

> 
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> arch/arm/boot/dts/omap5-uevm.dts | 60 ++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 60 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
>> index be659e8..19f5f0a 100644
>> --- a/arch/arm/boot/dts/omap5-uevm.dts
>> +++ b/arch/arm/boot/dts/omap5-uevm.dts
>> @@ -17,6 +17,66 @@
>>                device_type = "memory";
>>                reg = <0x80000000 0x7F000000>; /* 2032 MB */
>>        };
>> +
>> +       evm_leds {
>> +               compatible = "gpio-leds";
>> +
>> +               led@1 {
> 
> Drop the unit address. There's no reg property.
> 
>> +                       label = "omap5:red:led";
>> +                       gpios = <&gpio9 17 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "mmc0";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@2 {
>> +                       label = "omap5:green:led";
>> +                       gpios = <&gpio9 18 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "mmc1";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@3 {
>> +                       label = "omap5:blue:led";
>> +                       gpios = <&gpio9 19 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "mmc2";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@4 {
>> +                       label = "omap5:green:led1";
>> +                       gpios = <&gpio9 2 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "default-on";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@5 {
>> +                       label = "omap5:green:led2";
>> +                       gpios = <&gpio9 3 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "default-on";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@6 {
>> +                       label = "omap5:green:led3";
>> +                       gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "heartbeat";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@7 {
>> +                       label = "omap5:green:led4";
>> +                       gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "heartbeat";
>> +                       default-state = "off";
>> +               };
>> +
>> +               led@8 {
>> +                       label = "omap5:green:led5";
>> +                       gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "heartbeat";
>> +                       default-state = "off";
>> +               };
>> +       };
>> };
>> 
>> &hdmi {
>> --
>> 2.7.3
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html