mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Hadli, Manjunath" <manjunath.hadli@ti.com>
To: "'Jon Povey'" <jon.povey@racelogic.co.uk>,
	"davinci-linux-open-source@linux.davincidsp.com" 
	<davinci-linux-open-source@linux.davincidsp.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"Nori, Sekhar" <nsekhar@ti.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] davinci: fix DM365 EVM video input mux bits
Date: Tue, 19 Jul 2011 10:59:49 +0530	[thread overview]
Message-ID: <B85A65D85D7EB246BE421B3FB0FBB593024BCEF73E@dbde02.ent.ti.com> (raw)
In-Reply-To: <1311046211-2849-1-git-send-email-jon.povey@racelogic.co.uk>

Jon,

The fix looks correct. As a part of a different implementation which will go soon upstream, this has been taken care of, where we have used macros 
CPLD_VIDEO_INPUT_MUX_TVP7002    0x1
CPLD_VIDEO_INPUT_MUX_IMAGER     0x2

So, if you can do the same, it will look better.

Thanks,
-Manju


On Tue, Jul 19, 2011 at 09:00:11, Jon Povey wrote:
> Video input mux settings for tvp7002 and imager inputs were swapped.
> Comment was correct.
> 
> Tested on EVM with tvp7002 input.
> 
> Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk>
> ---
> As a bugfix maybe this should try to get into 3.0?
> 
>  arch/arm/mach-davinci/board-dm365-evm.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c
> index c67f684..09a87e6 100644
> --- a/arch/arm/mach-davinci/board-dm365-evm.c
> +++ b/arch/arm/mach-davinci/board-dm365-evm.c
> @@ -520,7 +520,7 @@ fail:
>  	 */
>  	if (have_imager()) {
>  		label = "HD imager";
> -		mux |= 1;
> +		mux |= 2;
>  
>  		/* externally mux MMC1/ENET/AIC33 to imager */
>  		mux |= BIT(6) | BIT(5) | BIT(3);
> @@ -540,7 +540,7 @@ fail:
>  		resets &= ~BIT(1);
>  
>  		if (have_tvp7002()) {
> -			mux |= 2;
> +			mux |= 1;
>  			resets &= ~BIT(2);
>  			label = "tvp7002 HD";
>  		} else {
> --
> 1.6.3.3
> 
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
> 


  reply	other threads:[~2011-07-19  5:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-19  3:30 Jon Povey
2011-07-19  5:29 ` Hadli, Manjunath [this message]
2011-07-19  6:28   ` Jon Povey
2011-07-19  7:25     ` Hadli, Manjunath
2011-07-19  9:00       ` Nori, Sekhar
2011-07-19 10:24         ` Hadli, Manjunath
2011-07-19  8:56 ` Nori, Sekhar
2011-07-19 10:55   ` Russell King - ARM Linux
2011-07-20 16:40     ` Nori, Sekhar
2011-07-20 16:48       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B85A65D85D7EB246BE421B3FB0FBB593024BCEF73E@dbde02.ent.ti.com \
    --to=manjunath.hadli@ti.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=jon.povey@racelogic.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®