From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbg154.qq.com (smtpbg154.qq.com [15.184.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FF0327A476; Mon, 2 Mar 2026 01:44:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=15.184.224.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772415867; cv=none; b=azWemQ5Q0dWcntPjTTIkNs1SdnQyOI5C3fIFT88v9TwBiPQn5sdniE3Vl10efbx7N13Bt6NsVOiDhEpx3CkXTcFKtaoUnshCS+HuTrn0lj2mcmEWkyY3JD47CZbUoczTG8Anu2xbEclaRi0ULZsW44Bk6O87rTZBqgBJ8sH/XnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772415867; c=relaxed/simple; bh=vUOHHdyEXrPGEk8AvCusVmyfpwCI2ekAWq+T8PVRPV0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j/1/+VF7yyy70W5Y324JqyawQUQq17sW589qGomrRSBEjvXrHMx23s6wP3ebcMoHGvkPT7BPD28zQNMG9cXuXZZjxbj+EMYWejjeIXegxDiHOhd5ZBCuyE2SLUzmRRMEhTt5K7JsYoWjEyiaMuO8V8UhhAbcByRljStncDouMlI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=TdUlJrRe; arc=none smtp.client-ip=15.184.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="TdUlJrRe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1772415732; bh=kRDQRl2R+LRWm2HggZ4Cj1vYHy4GXuClk7m0o1am4dw=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=TdUlJrRe6KoS6xPDpC5kBRbyw/L7QLvDkZ3u7sTb103KPWW+/AUiz8x8gpJKwKhio YjlQsoU5WuN5BNeDdoIi6Mo+ph6AI+Ub6XhcA/hWiJSgvLK9CZ9b9BTRE1KUX+y0Qo QUofJeo6ADr9uUNBnRLOCXxScSqsNYBheuMm9VlY= X-QQ-mid: zesmtpsz8t1772415723tcf6f7fb4 X-QQ-Originating-IP: w6IfNoMZkeVc0lyzIsKr9uYgMmtkBko/Qpg4ezv6sio= Received: from [10.2.99.140] ( [116.237.103.163]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 02 Mar 2026 09:41:59 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 4156359098192319691 Message-ID: Date: Mon, 2 Mar 2026 09:41:55 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/8] dt-bindings: iommu: Add spacemit/t100 features To: Conor Dooley Cc: Conor Dooley , Tomasz Jeznach , Joerg Roedel , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Yixun Lan , Jingyu Li , Zong Li , Yaxing Guo , iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <177231592262.848068.18080490567217057666@spud> <20260301-acclimate-suburb-fc46da7e0cea@spud> Content-Language: en-US From: Lv Zheng In-Reply-To: <20260301-acclimate-suburb-fc46da7e0cea@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz5b-1 X-QQ-XMAILINFO: NTHY/YkN8c+xXjKPQhQQ8z6eRFGBjzhi4ywoP07wySu7NtbvDlHpINhr Pz71ihPECjDvoVUYu4bOJShhop0qXeO/e6VWR2mxAL1OJdgg8SyQl4r89L9NDQW36IrH1tf 9LIDObU06QeBqm2idDg5fkfpi8mcQB7amzlQ9ANNVR34Zc0UKkYDzsjfQjX1t3sakX9NMV3 7GrTFziluMK8RXcwGIgyEOjrnhdlqLV04/4ldNa+x9XiMlRLdyBg4Vwzyt2I7PTGBBB4MLd FwBZMC0DWuU/7ko5WKERfFXndmdrz1ny4rIaeACrDVBG8ylt91hIr+7lEK6XkeHhn9sncJI PkUvLVI4qI3yi1BtHE80IJn/II1474R+ro+5hBacLeQK7n1+LErbRuoky8CXCzrA1OADUhQ V4hiYkwB9jiAzLTeaA78rQ+KNS2zNikOTtAAqHOv2PK24+aqs9Xmx18JwSj+V7rKIHug1CX ZyK0t/Z4wdhB+3uVhTzQzNo7tSfC8kmh59B79rL+ATK77H8P6kq581THWQpcQxalCj+Qq3u xu40K/MKx45Rumf9pe0hdNAj9Z9CZtoEx9jq42y1WE9sgyHnV6UV1DGMUrUOUXEBpgX/BZN CuJ23Gmw+zwNeW0nJLeGCFRDmPnlMGkM8sheofomhz//A3Wh9q4XyKPrAcXftBbrMj0ZeoS +LWA/0FChficDcMmeYQbO2JiVeDY8jVD1syWj0sMsrEI4o25OeQHXMSBdKfFqGCetBglK4x NbbvDJFwYNNduH8hINU3P5UQu9lmLpNHoAmIj9jm5WLizfBu7PpllOxeOrHFsGyK7/gfHDt oWnSrK3a1HpTaAy4VhEgiDqFhcZpnCEBMPRQu6aG/8PNPe2jdLJr0QXfumC37HFsVRAwI4U o8302hBghm68Fp6cndgbo3kTwGzraWx8VjXIn9L/Ju/vY8Pt+rKrX06qINnZmkO3tB2bVVH 3zFj1G9owW9FlGYH120cZcBLFyhsIa1GrHCyZ8Be0Nak0vcYCRt0jOd7QuupyWMDQnMErCX kD0Agjj0aDeXlrE22d X-QQ-XMRINFO: M/715EihBoGS47X28/vv4NpnfpeBLnr4Qg== X-QQ-RECHKSPAM: 0 On 3/1/2026 10:01 PM, Conor Dooley wrote: > On Sun, Mar 01, 2026 at 11:48:37AM +0800, Lv Zheng wrote: >> On 3/1/2026 5:58 AM, Conor Dooley wrote: >>> On Sat, 28 Feb 2026 22:44:49 +0800, Lv Zheng wrote: >>>> Adds device tree bindings for SpacemiT T100 specific features by >>>> introducing spacemit,t100 compatible. T100 contains distributed IOATCs, >>>> each of which exposes pmiv interrupt. >>>> >>>> Signed-off-by: Lv Zheng >>>> Signed-off-by: Jingyu Li >>> >>> Patch content here is fine, but the signoff chain on this patch is not >>> right. What did Jingyu do? You're author and submitter so either Jingyu >>> did nothing and should be removed, or is a co-developer which requires >>> attribution via the co-developed-by tag. If the latter, their signoff >>> should be before yours (the submitter is always last). >>> >>> pw-bot: changes-requested >> >> She is responsible for the common HPM part, and I just gave my comments to >> help to improve the quality of that implementation. >> I was just focusing on enabling and maintaining the T100 specific features. >> >> Our patches will go each other's local repository, leaving such tracks. That >> means the patch from me is Reviewed-and-tested-by her. >> And I'm responsible for sending the whole patchset for upstreaming. > > Then you need to either fix your email setup (because it's not inserting > From: Jingyu Li ) so that she is marked as the > author or actually set her to the author in git if you haven't. > Currently it looks like this when applied: > commit 872978c875731be43e84bec38798cb8ecd42b7a0 > Author: Lv Zheng > Date: Sat Feb 28 22:44:49 2026 +0800 > > dt-bindings: iommu: Add spacemit/t100 features > > Adds device tree bindings for SpacemiT T100 specific features by > introducing spacemit,t100 compatible. T100 contains distributed IOATCs, > each of which exposes pmiv interrupt. > > Signed-off-by: Lv Zheng > Signed-off-by: Jingyu Li > > In both cases, you need to change the order of signoffs so that yours is > last as the submitter. OK. BTW, since this version of this patch has been worked out all due your constructive feedback and suggestions. Now that it has functionally converged to what the community requested, can I add "Reviewed-by: Conor Dooley " for its next version? Best regards, Lv