From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44CE43C0A09 for ; Mon, 6 Jul 2026 06:18:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783318714; cv=none; b=AG7YqylIc4LNMYFbO/WnyxYnzsfytXgYwlzrLV+IB3t3S8b5wa4rds1nXRvrcTutw+MoaC97AWA+QlGVipnci6U/+7NYYvZK3Uz2n9BeSn7uzsNC4d2uK+nBxu6ZLKtHpPl9A/V2Qsa4QonS+Tm9bees4uciON4an1ZxWiSvQGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783318714; c=relaxed/simple; bh=i5XC2Tj6s+sKAPaaD920eU1gJdUaFkMeb3QdotAZR1g=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=Gr4qa33jH5Uc6yRKZ/diZLcH1iBTzfUfhnj6cv6WHrBDoBSVaROZOJy6TEnUYYguI9sD8XN59K2okMQFg/dm0RehmaOabT2yN9J7i+4Fj+DLOLx2zT+kpqBICy9Z3+qDxWtbHaJvFZn97R3QeyAUneMTYddsC8kgju8ZC4j+aE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=qedUTxBs; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="qedUTxBs" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783318707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QZ6xgAdYKS8O1X/lOii7G38Nbi208QlwMN5ZwaD1TsA=; b=qedUTxBsENU1qehZ7iaKg/Xctt7LvcJZpNxSlesJ/mwYWyigCbtelsI3ODOXTSQijg7W+C u0h4kD1mO0sPrwBZ+VN2xZHG8w5hqGQe4MXUTgyijOzuNs/WZcXWAB1n7lXGoyKPAkfb6h hWL2Nbx3uEedRhexwrQfwhUT+jd1av0= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH v3] mm/hugetlb: Fix null nodemask in alloc_fresh_hugetlb_folio X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20260705175119.440599-1-souravpanda@google.com> Date: Mon, 6 Jul 2026 14:17:39 +0800 Cc: osalvador@suse.de, akpm@linux-foundation.org, david@kernel.org, surenb@google.com, fvdl@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260705175119.440599-1-souravpanda@google.com> To: Sourav Panda X-Migadu-Flow: FLOW_OUT > On Jul 6, 2026, at 01:51, Sourav Panda wrote: >=20 > alloc_buddy_hugetlb_folio_with_mpol() can pass a NULL nodemask to > alloc_fresh_hugetlb_folio() as a fallback to allocate from all > nodes. If order is gigantic, alloc_fresh_hugetlb_folio() propagates > the NULL nodemask down to hugetlb_cma_alloc_frozen_folio() which = blindly > dereferences it in for_each_node_mask(), leading to a null pointer > dereference. >=20 > Similarly, if the CMA allocation fails, the fallback > alloc_contig_frozen_pages() is also called with a NULL nodemask, > which may cause issues. >=20 > Fix this by explicitly checking if nodemask is NULL in > alloc_fresh_hugetlb_folio() and defaulting to > cpuset_current_mems_allowed. This ensures that both the CMA and > contiguous allocators receive a valid nodemask safely using a seqcount > loop to prevent torn reads. >=20 > =46rom a userspace perspective, this bug allows an unprivileged user = to > crash the kernel (trigger a panic) by requesting a gigantic hugepage > allocation with MPOL_PREFERRED_MANY on a system where CMA is only > configured on a subset of NUMA nodes. >=20 > This can be reproduced by booting a VM with two NUMA nodes, = restricting > CMA to Node 1 (e.g., hugetlb_cma=3D1:1G default_hugepagesz=3D1G = hugepagesz=3D1G > hugepages=3D0), and running a program that allocates a 1GB hugepage = area > without reserving, restricts allocation to Node 0 using mbind() with > MPOL_PREFERRED_MANY, and triggers a page fault: >=20 > void *ptr =3D mmap(NULL, 1UL << 30, PROT_READ | PROT_WRITE, > MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB | > MAP_HUGE_1GB | MAP_NORESERVE, -1, 0); > unsigned long nodemask =3D 1; /* Node 0 */ > mbind(ptr, 1UL << 30, MPOL_PREFERRED_MANY, &nodemask, > sizeof(nodemask) * 8, 0); > memset(ptr, 0, 1UL << 30); /* Trigger fault */ >=20 > This results in a NULL pointer dereference: >=20 > BUG: kernel NULL pointer dereference, address: 0000000000000000 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not-present page > Oops: Oops: 0000 [#1] SMP NOPTI > RIP: 0010:hugetlb_cma_alloc_frozen_folio+0x75/0x120 > Call Trace: > > only_alloc_fresh_hugetlb_folio.isra.0+0x2c/0x160 > alloc_surplus_hugetlb_folio+0x6d/0x100 > alloc_hugetlb_folio+0x3c5/0x660 > hugetlb_no_page+0x3d9/0x650 >=20 > Additionally, this patch adds a missing node_isset(nid, *nodemask) = check > in hugetlb_cma_alloc_frozen_folio() to ensure the initial node = allocation > attempt respects the memory policy. >=20 > Fixes: eb02f14c4a2b ("mm/hugetlb: allow overcommitting gigantic = hugepages") > Cc: stable@vger.kernel.org > Signed-off-by: Sourav Panda > --- > Changes in v3: > - Condensed the reproducer and QEMU setup from v1 discussion into a = readable summary per Andrew Morton. > - Safely read cpuset_current_mems_allowed using a seqcount loop to = prevent torn reads. > - v2: = https://lore.kernel.org/linux-mm/20260704174930.2885785-1-souravpanda@goog= le.com/ > - v1: = https://lore.kernel.org/linux-mm/20260702215713.627941-1-souravpanda@googl= e.com/ > mm/hugetlb.c | 12 ++++++++++++ > mm/hugetlb_cma.c | 2 +- > 2 files changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 571212b80835..ee67ea29c003 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1864,6 +1864,18 @@ static struct folio = *alloc_fresh_hugetlb_folio(struct hstate *h, > gfp_t gfp_mask, int nid, nodemask_t *nmask) > { > struct folio *folio; > + nodemask_t local_node_mask; > + > + if (!nmask) { > + unsigned int cpuset_mems_cookie; > + > + do { > + cpuset_mems_cookie =3D = read_mems_allowed_begin(); > + local_node_mask =3D cpuset_current_mems_allowed; > + } while (read_mems_allowed_retry(cpuset_mems_cookie)); > + > + nmask =3D &local_node_mask; > + } As Andrew pointed it out, it is not helpful to prevent any = false-positive allocation failures. We need something like the following: seq =3D read_mems_allowed_begin(); alloc_nodemask =3D nodemask; if (cpusets_enabled() && !alloc_nodemask) alloc_nodemask =3D &cpuset_current_mems_allowed; for_each_node_mask(node, alloc_nodemask) { if (cpusets_enabled() && nodemask && !cpuset_zone_allowed(zone, gfp_mask)) continue; ... } if (!page && read_mems_allowed_retry(seq)) goto retry; After further consideration, I believe we only need to fix alloc_gigantic_frozen_folio(), as alloc_buddy_frozen_folio() already handles the NULL nodemask properly via prepare_alloc_pages(). To address the issue in alloc_gigantic_frozen_folio(), we have two potential options: - Option 1: Fix it directly within alloc_gigantic_frozen_folio(). This would centrally cover both of its underlying allocation paths: hugetlb_cma_alloc_frozen_folio() and alloc_contig_frozen_pages(). - Option 2: Fix hugetlb_cma_alloc_frozen_folio() and = alloc_contig_frozen_pages() separately. The rationale here is that since the buddy allocator already handles this case internally, and alloc_contig_frozen_pages() is also a low-level allocator, it would be better to keep their = behaviors consistent. Both approaches are viable from my perspective. I'm CCing more MM = maintainers and reviewers to gather your insights and decide on the best path = forward. Muchun, Thanks. >=20 > folio =3D only_alloc_fresh_hugetlb_folio(h, gfp_mask, nid, = nmask, NULL); > if (folio) > diff --git a/mm/hugetlb_cma.c b/mm/hugetlb_cma.c > index 39344d6c78d8..79dbd0baafa3 100644 > --- a/mm/hugetlb_cma.c > +++ b/mm/hugetlb_cma.c > @@ -34,7 +34,7 @@ struct folio *hugetlb_cma_alloc_frozen_folio(int = order, gfp_t gfp_mask, > if (!hugetlb_cma_size) > return NULL; >=20 > - if (hugetlb_cma[nid]) > + if (hugetlb_cma[nid] && node_isset(nid, *nodemask)) > page =3D cma_alloc_frozen_compound(hugetlb_cma[nid], = order); >=20 > if (!page && !(gfp_mask & __GFP_THISNODE)) { > --=20 > 2.55.0.rc0.799.gd6f94ed593-goog >=20