From: Kumar Gala <galak@kernel.crashing.org>
To: Liu Gang <Gang.Liu@freescale.com>
Cc: <linuxppc-dev@lists.ozlabs.org>, <Alexandre.Bounine@idt.com>,
<akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>,
<r58472@freescale.com>, <r61911@freescale.com>,
Shaohui Xie <Shaohui.Xie@freescale.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit
Date: Tue, 6 Mar 2012 11:46:20 -0600 [thread overview]
Message-ID: <B946A444-73EC-4A70-AA7E-31FAF31FFF13@kernel.crashing.org> (raw)
In-Reply-To: <1330957222.23420.136.camel@10.ap.freescale.net>
On Mar 5, 2012, at 8:20 AM, Liu Gang wrote:
> Hi, Kumar,
>
> On Fri, 2012-03-02 at 09:11 -0600, Kumar Gala wrote:
>>> diff --git a/arch/powerpc/sysdev/fsl_rmu.c b/arch/powerpc/sysdev/fsl_rmu.c
>>> index 1548578..468011e 100644
>>> --- a/arch/powerpc/sysdev/fsl_rmu.c
>>> +++ b/arch/powerpc/sysdev/fsl_rmu.c
>>> @@ -311,8 +311,8 @@ fsl_rio_dbell_handler(int irq, void *dev_instance)
>>>
>>> /* XXX Need to check/dispatch until queue empty */
>>> if (dsr & DOORBELL_DSR_DIQI) {
>>> - u32 dmsg =
>>> - (u32) fsl_dbell->dbell_ring.virt +
>>> + unsigned long dmsg =
>>> + (unsigned long) fsl_dbell->dbell_ring.virt +
>>> (in_be32(&fsl_dbell->dbell_regs->dqdpar) & 0xfff);
How about a struct instead:
struct rmu_dmsg {
u16 dummy;
u16 tid;
u16 sid;
u16 info;
};
struct rmu_dmsg *dmsg = fsl_dbell->dbell_ring.virt + (in_be32(&fsl_dbell->dbell_regs->dqdpar) & 0xfff);
Than you can git rid of the DBELL_* macros.
- k
next prev parent reply other threads:[~2012-03-06 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 7:08 Liu Gang
2012-03-02 9:57 ` David Laight
2012-03-02 14:30 ` Paul Gortmaker
2012-03-05 2:52 ` Liu Gang
2012-03-02 15:11 ` Kumar Gala
2012-03-05 14:20 ` Liu Gang
2012-03-06 17:46 ` Kumar Gala [this message]
2012-03-07 12:52 ` Liu Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B946A444-73EC-4A70-AA7E-31FAF31FFF13@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=Alexandre.Bounine@idt.com \
--cc=Gang.Liu@freescale.com \
--cc=Shaohui.Xie@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paul.gortmaker@windriver.com \
--cc=r58472@freescale.com \
--cc=r61911@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®