From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E78AC77B7C for ; Tue, 9 May 2023 15:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235671AbjEIPRR (ORCPT ); Tue, 9 May 2023 11:17:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235086AbjEIPRP (ORCPT ); Tue, 9 May 2023 11:17:15 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4F6244B8 for ; Tue, 9 May 2023 08:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683645388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MDzfBWP3pjVUkb9AGu0G6Wtedp0sdaxtshvvGxbi+yI=; b=d4+Wvw7gobaYLaEUe2M5ESAgrHIMegal3MPanZ5AqyxYnte/BB/8RlThjNujAqN6ryRnCt 5woskZBR0C/nlfik5nQzdwODIXPiFKi6pvTBWT2kt/4IEuRJjVd/M8zZrO/VSdIhSOu3c8 ReTb+gUnCkXwYhJAhfXr/+BWvrSScgA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-260-r1aQFDHuN0SFkV1Y2ICV-Q-1; Tue, 09 May 2023 11:16:26 -0400 X-MC-Unique: r1aQFDHuN0SFkV1Y2ICV-Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80FD1895689; Tue, 9 May 2023 15:16:25 +0000 (UTC) Received: from [192.168.37.1] (unknown [10.22.50.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F243C15BA0; Tue, 9 May 2023 15:16:24 +0000 (UTC) From: Benjamin Coddington To: Chengen Du Cc: trond.myklebust@hammerspace.com, anna@kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] NFS: Add mount option 'nofasc' Date: Tue, 09 May 2023 11:16:23 -0400 Message-ID: In-Reply-To: References: <20230411030248.53356-1-chengen.du@canonical.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24 Apr 2023, at 21:41, Chengen Du wrote: > Hi, > > May I ask if there are any concerns or opinions regarding the > introduction of the new mount option? > If there is a more suitable solution, we can discuss it, and I can > work on implementing it. I suspect there's some weariness of mount options, we have a lot of them and they are not easily removed once implemented. Additionally, requests to add them usually can show the appropriate changes to the nfs-utils mount.nfs and man pages required. Incompleteness here may be the reason you're not hearing back from a maintainer. However, without guidance from a maintainer, you might end up doing extra work trying to meet unclear standards. There's a couple of other ways to address the access cache performance "degradation" that was introduced by the changes that other folks desperately needed for correctness. We can change nfs_access_login_time to have a module parameter modifying the behavior. The downside is this would affect every mount. We can grow a sysfs knob to change the behavior. Downside is we only have very preliminary sysfs scaffolding as of yet. However, if you want to keep pushing for the mount option, I'd suggest doing a v2 with the userspace patches, and if that gets ignored then do a "PATCH RESEND" on that a month or so before each mainline merge window. I've found that bump-replying to old patches isn't as effective at getting work merged here. I believe the maintainers want to see that you're rebasing as mainline progresses, and you have active ownership over the work to fix bugs that may follow or address other fallout from the community. Ben