From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CBBDC433B4 for ; Sat, 15 May 2021 13:26:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D2AA613C1 for ; Sat, 15 May 2021 13:26:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230508AbhEON1j convert rfc822-to-8bit (ORCPT ); Sat, 15 May 2021 09:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbhEON1a (ORCPT ); Sat, 15 May 2021 09:27:30 -0400 X-Greylist: delayed 86 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 15 May 2021 06:26:16 PDT Received: from bounceout06.ispgateway.de (bounceout06.ispgateway.de [IPv6:2a00:1158:400:1::f6]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6EDA5C061573 for ; Sat, 15 May 2021 06:26:16 -0700 (PDT) Received: from [80.67.18.14] (helo=smtprelay02.ispgateway.de) by bounceout06.ispgateway.de with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lhuHf-0006gU-LF; Sat, 15 May 2021 15:24:47 +0200 Received: from [193.16.224.13] (helo=smtpclient.apple) by smtprelay02.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lhU6k-0000Op-2I; Fri, 14 May 2021 11:27:46 +0200 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Subject: Re: [PATCH v2] samples/kprobes: Fix typo in handler_post() From: "Koderer, Marc" In-Reply-To: <1620979810-12779-1-git-send-email-yangtiezhu@loongson.cn> Date: Fri, 14 May 2021 11:28:07 +0200 Cc: Jonathan Corbet , Masami Hiramatsu , Mauro Carvalho Chehab , Christian Brauner , Martin Schwidefsky , Johannes Thumshirn , Heiko Carstens , Jisheng Zhang , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1620979810-12779-1-git-send-email-yangtiezhu@loongson.cn> To: Tiezhu Yang X-Mailer: Apple Mail (2.3654.80.0.2.43) X-Df-Sender: bWFyY0Brb2RlcmVyLmNvbQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 14. May 2021, at 10:10, Tiezhu Yang wrote: > > It should use post_handler instead of pre_handler in handler_post(). > > Fixes: e16c5dd5157e ("samples/kprobes: Add s390 case in kprobe example module") > Signed-off-by: Tiezhu Yang LGTM. Acked-by: Marc Koderer Thanks. > --- > > v2: rebase on the latest mainline kernel > > samples/kprobes/kprobe_example.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c > index c495664..602db3f 100644 > --- a/samples/kprobes/kprobe_example.c > +++ b/samples/kprobes/kprobe_example.c > @@ -89,7 +89,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs, > p->symbol_name, p->addr, regs->status); > #endif > #ifdef CONFIG_S390 > - pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n", > + pr_info("<%s> post_handler: p->addr, 0x%p, flags = 0x%lx\n", > p->symbol_name, p->addr, regs->flags); > #endif > } > -- > 2.1.0 >