From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gimli.kloenk.de (gimli.kloenk.de [49.12.72.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D9AA1B85F1; Tue, 24 Sep 2024 19:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.12.72.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727205799; cv=none; b=UrLp/DBT0a1jnHRybpMnOOEghwM7lZuhKC+0TgbyPy7ugnSGjlHkQUTxKZ2VQ87qBjZNDycJE6ZTPFcGnmYTCACzWBKKISIjCa7SIUCuc/M30gqt20uSDgSt3UrApnFNBbGTDp8dQfgk9phc610uYm8bCdzQWv7e8+zg+XS28Vg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727205799; c=relaxed/simple; bh=+FHMJ6hwPtvMrBdLQmrt8NWojAbBrIxp5Zb2NmvI6FQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SRqYt/LCIT4Uh+nK7TSkFgGXvdt/rL7dokJ7kgNVKnGmd6PasvooLNN8J+e9ZhLd6ABBn3lwSrtOHHJex5EeO9z+UE70NzGQXn8viarzpnDKue4d2RUg3udWrgB5ZSeeiE8kNLVkFSHm2FGdgHhO+tIkIkDhTPE7nruMODakPlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kloenk.dev; spf=pass smtp.mailfrom=kloenk.dev; dkim=pass (1024-bit key) header.d=kloenk.dev header.i=@kloenk.dev header.b=mT5uwr6l; arc=none smtp.client-ip=49.12.72.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kloenk.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kloenk.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kloenk.dev header.i=@kloenk.dev header.b="mT5uwr6l" From: Fiona Behrens DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kloenk.dev; s=mail; t=1727205783; bh=Kff+VYEu37RPJB/1j/mf3tSijU1+C9nLFtyrPFa3P7Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mT5uwr6lwqqNZRkcV6aORlqwUs1djKRH5hDIgws/UsCUp9fvUAvKi4CcH46+S5SEE +m3bXkuirs+uvZEten8ky9Nmfc0r4E9CPeI5KHDhUPtY7hHaLxADK6qo78URsKfMTR f9aCIqRC3vB97PHR0S6JLZwBEzIzFbqSMY51nUSU= To: Miguel Ojeda Cc: Masahiro Yamada , Fiona Behrens , linux-kbuild@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alice Ryhl , Andreas Hindborg , Benno Lossin , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Boqun Feng , Gary Guo , Nathan Chancellor , Nicolas Schier Subject: Re: [PATCH] kbuild: remove unnecessary export of RUST_LIB_SRC Date: Tue, 24 Sep 2024 21:23:02 +0200 Message-ID: In-Reply-To: References: <20240913180622.1327656-1-masahiroy@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24 Sep 2024, at 20:42, Miguel Ojeda wrote: > On Fri, Sep 13, 2024 at 8:06=E2=80=AFPM Masahiro Yamada wrote: >> >> This code was added by this commit: >> >> https://github.com/Rust-for-Linux/linux/commit/3f46885dc03ed2d750085b= 2237078a1628323964 >> >> Please me know if I am missing something. > > I think it is OK -- unless Fiona recalls something: As long as the export to rustc and the rust analyzer script works this lo= oks good. Acked-by: Fiona Behrens > > Acked-by: Miguel Ojeda > Tested-by: Miguel Ojeda > > Thanks Masahiro for the simplification! > > Cheers, > Miguel