From: Grant Likely <grant.likely@secretlab.ca>
To: Oliver Neukum <oliver@neukum.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [RFC PATCH] input: Add wiichuck driver
Date: Sat, 14 May 2011 21:20:04 +0200 [thread overview]
Message-ID: <BANLkTi=4oCehWLXrKbd6bj2CuoxDXdBHAg@mail.gmail.com> (raw)
In-Reply-To: <201105142117.50529.oliver@neukum.org>
On Sat, May 14, 2011 at 9:17 PM, Oliver Neukum <oliver@neukum.org> wrote:
> Am Donnerstag, 12. Mai 2011, 06:29:44 schrieb Grant Likely:
>> +static void wiichuck_poll(struct input_polled_dev *poll_dev)
>> +{
>> + struct wiichuck_device *wiichuck = poll_dev->private;
>> + struct i2c_client *i2c = wiichuck->i2c_client;
>> + static uint8_t cmd_byte = 0;
>> + struct i2c_msg cmd_msg =
>> + { .addr = i2c->addr, .len = 1, .buf = &cmd_byte };
>> + uint8_t b[6];
>> + struct i2c_msg data_msg =
>> + { .addr = i2c->addr, .flags = I2C_M_RD, .len = 6, .buf = b };
>
>
> Do you need these buffers to be capable of DMA?
Good point. Yes, these buffers should be DMA capable. I'll pull them
off the stack.
g.
next prev parent reply other threads:[~2011-05-14 19:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 4:29 Grant Likely
2011-05-12 6:24 ` simon
2011-05-15 21:17 ` Grant Likely
2011-05-14 19:17 ` Oliver Neukum
2011-05-14 19:20 ` Grant Likely [this message]
2011-05-16 16:44 ` Dmitry Torokhov
2011-05-16 18:31 ` Grant Likely
2011-05-16 19:44 ` Dmitry Torokhov
2011-05-16 21:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=4oCehWLXrKbd6bj2CuoxDXdBHAg@mail.gmail.com' \
--to=grant.likely@secretlab.ca \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®