From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758896Ab1FQNAB (ORCPT ); Fri, 17 Jun 2011 09:00:01 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:33639 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758618Ab1FQNAA (ORCPT ); Fri, 17 Jun 2011 09:00:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=qEVh5gjdHSXYigIyvQ1crJivXPdRXyWsKyv9NqXTVVuyEXimAFazWLOw9ES6aXRZEY t3sfZozhPZLLWGy5OsiFcU8u3I7uyw2tCtzn6qFPcswk7IaLpTyAjTrF7e96vOCATTlU 8rXkRIPixapEVezpiUWPWDtR6Y39y5F20WfP4= MIME-Version: 1.0 In-Reply-To: <1308275405.9218.156.camel@gandalf.stny.rr.com> References: <1308275405.9218.156.camel@gandalf.stny.rr.com> Date: Fri, 17 Jun 2011 20:59:59 +0800 Message-ID: Subject: Re: [PATCH] sched: update cpupri for runqueue when its priority changes From: Hillf Danton To: Steven Rostedt Cc: LKML , Mike Galbraith , Yong Zhang , Peter Zijlstra , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2011 at 9:50 AM, Steven Rostedt wrote: > On Sun, 2011-06-05 at 17:54 +0800, Hillf Danton wrote: >> When the priority of runqueue changes, lower or higer, the info of cpupri >> should be updated, in cases such as pick_next_task_rt() and switched_to_rt(). > > Why? > > We do the calculation on queuing and dequeuing the task, we only care > about the highest priority task that is on the queue, not what is > actually running. > It is to capture the changes in CPU priority caused by re-queued task and throttled RQ. Hillf