From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754152Ab1DEP3E (ORCPT ); Tue, 5 Apr 2011 11:29:04 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:61269 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753996Ab1DEP3A convert rfc822-to-8bit (ORCPT ); Tue, 5 Apr 2011 11:29:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=HfDmeKe/SYMh77J/vxdrvHDkAKi8fyJaudsgR9LYdjIkyBYjyU2j5OnS/Qkvgc8UrD tiYc04Mcvzeu1mFWdO2W3ghqxgPD5an0hyk3UUYG7ywSwAZNhAr6ue0uTMiHsQEtfELg tMGJM0Qkw2co1L1mu8GNtem2+R/9cAbKIrqJw= MIME-Version: 1.0 In-Reply-To: <1302015561-21047-20-git-send-email-mmarek@suse.cz> References: <1302015561-21047-1-git-send-email-mmarek@suse.cz> <1302015561-21047-20-git-send-email-mmarek@suse.cz> Date: Tue, 5 Apr 2011 17:28:59 +0200 Message-ID: Subject: Re: [PATCH 19/34] rt2x00: Drop __TIME__ usage From: Gertjan van Wingerde To: Michal Marek Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Ivo van Doorn , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 5, 2011 at 4:59 PM, Michal Marek wrote: > The kernel already prints its build timestamp during boot, no need to > repeat it in random drivers and produce different object files each > time. > > Cc: Ivo van Doorn > Cc: Gertjan van Wingerde > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Michal Marek Note that this timestamp is not in the kernel log, but in a special debug file in debugfs. However, I cannot see how a timestamp is actually useful for debugging the driver, so Acked-by: Gertjan van Wingerde > --- >  drivers/net/wireless/rt2x00/rt2x00debug.c |    1 - >  1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c > index c92db32..66166ef 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00debug.c > +++ b/drivers/net/wireless/rt2x00/rt2x00debug.c > @@ -568,7 +568,6 @@ static struct dentry *rt2x00debug_create_file_driver(const char *name, >        blob->data = data; >        data += sprintf(data, "driver:\t%s\n", intf->rt2x00dev->ops->name); >        data += sprintf(data, "version:\t%s\n", DRV_VERSION); > -       data += sprintf(data, "compiled:\t%s %s\n", __DATE__, __TIME__); >        blob->size = strlen(blob->data); > >        return debugfs_create_blob(name, S_IRUSR, intf->driver_folder, blob); > -- > 1.7.4.1 > > -- --- Gertjan