From: Maxin John <maxin.john@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Michal Nazarewicz <mina86@mina86.com>,
gregkh@suse.de, stern@rowland.harvard.edu, m-sonasath@ti.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
roger.quadros@nokia.com
Subject: Re: [PATCH] usb: gadget: f_mass_storage: Remove the LUN check which is always true
Date: Sat, 7 May 2011 12:27:58 +0300 [thread overview]
Message-ID: <BANLkTikPgm7kpaoofVSkJCBXYyea4HeB8A@mail.gmail.com> (raw)
In-Reply-To: <20110507010927.GA32142@kroah.com>
Hi Greg,
>> Please find the patch for "file_storage.c" below. Should I merge these
>> two patches and re-submit as a single one?
>
> Yes please.
As per your suggestion, please find the merged patch below:
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
diff --git a/drivers/usb/gadget/f_mass_storage.c
b/drivers/usb/gadget/f_mass_storage.c
index 6d8e533..cade79e 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -1910,7 +1910,7 @@ static int check_command(struct fsg_common
*common, int cmnd_size,
common->lun, lun);
/* Check the LUN */
- if (common->lun >= 0 && common->lun < common->nluns) {
+ if (common->lun < common->nluns) {
curlun = &common->luns[common->lun];
common->curlun = curlun;
if (common->cmnd[0] != REQUEST_SENSE) {
diff --git a/drivers/usb/gadget/file_storage.c
b/drivers/usb/gadget/file_storage.c
index a6eacb5..a9c5177 100644
--- a/drivers/usb/gadget/file_storage.c
+++ b/drivers/usb/gadget/file_storage.c
@@ -2314,7 +2314,7 @@ static int check_command(struct fsg_dev *fsg,
int cmnd_size,
fsg->lun = lun; // Use LUN from the command
/* Check the LUN */
- if (fsg->lun >= 0 && fsg->lun < fsg->nluns) {
+ if (fsg->lun < fsg->nluns) {
fsg->curlun = curlun = &fsg->luns[fsg->lun];
if (fsg->cmnd[0] != REQUEST_SENSE) {
curlun->sense_data = SS_NO_SENSE;
next prev parent reply other threads:[~2011-05-07 9:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 14:16 Maxin John
2011-05-04 14:27 ` Michal Nazarewicz
2011-05-04 15:04 ` Maxin John
2011-05-04 15:41 ` Michal Nazarewicz
2011-05-04 16:02 ` Alan Stern
2011-05-07 1:09 ` Greg KH
2011-05-07 9:27 ` Maxin John [this message]
2011-05-07 15:43 ` Greg KH
2011-05-08 11:51 ` Maxin John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikPgm7kpaoofVSkJCBXYyea4HeB8A@mail.gmail.com \
--to=maxin.john@gmail.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m-sonasath@ti.com \
--cc=mina86@mina86.com \
--cc=roger.quadros@nokia.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®