Re: [PATCH] sched: remove noop in next_prio()

[Yong Zhang <yong.zhang0@gmail.com>]

On Sat, May 21, 2011 at 10:19 PM, Hillf Danton <dhillf@gmail.com> wrote:
> When computing the next priority for a given run-queue, the check for
> RT priority of the task determined by the pick_next_highest_task_rt()
> function could be removed, since only RT task is returned by the
> function.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>

Yup, it's true.

Reviewed-by: Yong Zhang <yong.zhang0@gmail.com>

> ---
>
> --- a/kernel/sched_rt.c 2011-04-27 11:48:50.000000000 +0800
> +++ b/kernel/sched_rt.c 2011-05-21 22:10:34.000000000 +0800
> @@ -670,7 +670,7 @@ static inline int next_prio(struct rq *r
>  {
>        struct task_struct *next = pick_next_highest_task_rt(rq, rq->cpu);
>
> -       if (next && rt_prio(next->prio))
> +       if (next)
>                return next->prio;
>        else
>                return MAX_RT_PRIO;
>



-- 
Only stand for myself