From: Rabin Vincent <rabin@rab.in>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: make KBUILD_NOCMDDEP=1 handle empty built-in.o
Date: Sun, 15 May 2011 23:07:19 +0530 [thread overview]
Message-ID: <BANLkTiktdW3N35YYDB6dmUOMG1ZbQpYrow@mail.gmail.com> (raw)
In-Reply-To: <20110512133356.GI13293@sepie.suse.cz>
On Thu, May 12, 2011 at 19:03, Michal Marek <mmarek@suse.cz> wrote:
> I'm not sure if this is the rigt way to fix it. Kbuild.include should
> not care about obj-*. The problem is that arg-check is always empty with
> KBUILD_NOCMDDEP and if there are no other dependencies, the target will
> not be created, right? IMO we only need to make sure that during the
> first make run, arg-check always expands to non-empty, even with
> KBUILD_NOCMDDEP. So we can drop the $(obj-y) test and do it like this
> (untested), can't we?
>
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index c034dd7..be39cd1 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -197,6 +197,8 @@ ifneq ($(KBUILD_NOCMDDEP),1)
> # User may override this check using make KBUILD_NOCMDDEP=1
> arg-check = $(strip $(filter-out $(cmd_$(1)), $(cmd_$@)) \
> $(filter-out $(cmd_$@), $(cmd_$(1))) )
> +else
> +arg-check = $(if $(strip $(cmd_$@)),,1)
> endif
>
> # >'< substitution is for echo to work,
This works for me, thanks.
Tested-by: Rabin Vincent <rabin@rab.in>
> while at it, we should also add KBUILD_NOCMDDEP to
> Documentation/kbuild/kbuild.txt.
I will try to write up something for this.
next prev parent reply other threads:[~2011-05-15 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 17:06 Rabin Vincent
2011-05-11 17:30 ` Rabin Vincent
2011-05-12 13:33 ` Michal Marek
2011-05-15 17:37 ` Rabin Vincent [this message]
2011-05-16 14:44 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTiktdW3N35YYDB6dmUOMG1ZbQpYrow@mail.gmail.com \
--to=rabin@rab.in \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®