From: Grant Likely <grant.likely@secretlab.ca>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
ARM Kernel <linux-arm-kernel@lists.infradead.org>,
Ryan Mallon <ryan@bluewatersys.com>
Subject: Re: [PATCH] gpio-ep93xx: convert to platform_driver and use basic_mmio_gpio library
Date: Thu, 9 Jun 2011 12:42:16 -0600 [thread overview]
Message-ID: <BANLkTim1_6LZ1u_p-uhf5dYQYuKTjSSqZQ@mail.gmail.com> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F3820B84D3@AUSP01VMBX24.collaborationhost.net>
On Thu, Jun 9, 2011 at 10:43 AM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> On Wednesday, June 08, 2011 3:08 PM, Grant Likely wrote:
>>
>> Merged, thanks.
>
> Thanks. I just noticed I left in a debug message I added when changing
> this to a platform_driver.
>
>>> +static int __init ep93xx_gpio_init(void)
>>> +{
>>> + pr_info("%s\n", __func__);
>>> + return platform_driver_register(&ep93xx_gpio_driver);
>>> }
>
> That pr_info shouldn't be there. It just adds noise.
>
> Would you prefer a full new patch or just an incremental patch to remove
> this line? The patch is already in next-20110609.
>
> Thanks, sorry for the trouble
Neither. I just fixed it up and pushed out a commit.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2011-06-09 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 21:35 H Hartley Sweeten
2011-06-08 22:07 ` Grant Likely
2011-06-09 16:43 ` H Hartley Sweeten
2011-06-09 18:42 ` Grant Likely [this message]
2011-06-09 18:44 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim1_6LZ1u_p-uhf5dYQYuKTjSSqZQ@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=hartleys@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ryan@bluewatersys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®