mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH] sched: correct how RT task is picked
Date: Wed, 11 May 2011 16:43:49 +0800	[thread overview]
Message-ID: <BANLkTim4n-WA_6nJpg4Nd99yuc3f+VWkcw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikkeR_yf1HGhgq7WEO-kEvDGkV_tw@mail.gmail.com>

On Tue, May 10, 2011 at 9:04 PM, Hillf Danton <dhillf@gmail.com> wrote:
> When picking RT task for given CPU,
> [1] if the cpu is invalid for cpumask test, right result could not be

'cpu is invalid' means weather we care it or not, it's not real 'invalid'

> reached even by further checking nr_cpus_allowed,
> on the other hand, the input cpu is valid in two cases that
> pick_next_highest_task_rt() is called, thus the invalid input cpu
> looks over-concern.
> [2] if the cpu is valid for cpumask test, further checking
> nr_cpus_allowed looks overwork, since it is computed based on
> cpus_allowed,

No, cpumask_test_cpu(cpu, &p->cpus_allowed) doesn't mean
p->rt.nr_cpus_allowed > 1.

Thanks,
Yong

> what is more, the combination of cpus_allowed and nr_cpus_allowed
> could lead to incorrect result if the input cpu == rq->cpu, as in the
> case of next_prio() where no pulling task is concerned.
>
> In this work, invalid cpu is not removed but leads to negative result,
> but nr_cpus_allowed is.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/kernel/sched_rt.c 2011-04-27 11:48:50.000000000 +0800
> +++ b/kernel/sched_rt.c 2011-05-10 20:30:38.000000000 +0800
> @@ -1149,10 +1149,12 @@ static void deactivate_task(struct rq *r
>
>  static int pick_rt_task(struct rq *rq, struct task_struct *p, int cpu)
>  {
> -       if (!task_running(rq, p) &&
> -           (cpu < 0 || cpumask_test_cpu(cpu, &p->cpus_allowed)) &&
> -           (p->rt.nr_cpus_allowed > 1))
> -               return 1;
> +       if (!task_running(rq, p)) {
> +               if (cpu < 0)
> +                       return 0;
> +               if (cpumask_test_cpu(cpu, &p->cpus_allowed))
> +                       return 1;
> +       }
>        return 0;
>  }
>



-- 
Only stand for myself

  reply	other threads:[~2011-05-11 15:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 13:04 Hillf Danton
2011-05-11  8:43 ` Yong Zhang [this message]
2011-05-11 13:44   ` Hillf Danton
2011-05-12 12:06     ` Yong Zhang
2011-05-18  1:38       ` Steven Rostedt
2011-05-18  2:31         ` Yong Zhang
2011-05-18 13:19           ` Hillf Danton
2011-05-18 13:24             ` Steven Rostedt
2011-05-18 14:46               ` Hillf Danton
2011-05-18 15:15                 ` Steven Rostedt
2011-05-18 15:20                   ` Peter Zijlstra
2011-05-19 12:49                     ` [PATCH resend] " Hillf Danton
2011-05-19  1:41                 ` [PATCH] " Yong Zhang
2011-05-19  1:44                   ` Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTim4n-WA_6nJpg4Nd99yuc3f+VWkcw@mail.gmail.com \
    --to=yong.zhang0@gmail.com \
    --cc=dhillf@gmail.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®