From: Linus Torvalds <torvalds@linux-foundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
gregkh@suse.de,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>, Tejun Heo <tj@kernel.org>
Subject: Re: tty breakage in X (Was: tty vs workqueue oddities)
Date: Fri, 3 Jun 2011 18:36:54 +0900 [thread overview]
Message-ID: <BANLkTim6VsynZHLagcu9Xo3EjsUz=54dYA@mail.gmail.com> (raw)
In-Reply-To: <1307084189.23876.19.camel@pasglop>
On Fri, Jun 3, 2011 at 3:56 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
>
> So I think my theory stands that flush_to_ldisc constantly reschedule
> itself causing the worker thread to eat all CPU and starve the consumer
> of the PTY. I won't have time to dig much deeper today nor probably this
> week-end so I'm sending this email for others who want to look.
Gaah - that commit is total and utter crap.
I *removed* the whole "reschedule the work queue again" crap. It was
totally wrong. See commit a5660b41af6a.
But then commit b1c43f82c5aa added the crap right back in.
So does it all work if you just remove the broken schedule_work() line
from flush_to_ldisc?
Otherwise we'll need to just revert it. The commit is clearly totally broken.
Linus
next prev parent reply other threads:[~2011-06-03 9:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 7:17 tty vs workqueue oddities Benjamin Herrenschmidt
2011-06-02 8:37 ` tty breakage in X (Was: tty vs workqueue oddities) Benjamin Herrenschmidt
2011-06-02 9:30 ` Andreas Schwab
2011-06-02 10:07 ` Alan Cox
2011-06-03 0:56 ` Benjamin Herrenschmidt
2011-06-03 6:17 ` Benjamin Herrenschmidt
2011-06-03 6:56 ` Benjamin Herrenschmidt
2011-06-03 9:36 ` Linus Torvalds [this message]
2011-06-05 14:37 ` Guillaume Chazarain
2011-06-06 14:24 ` Guillaume Chazarain
2011-06-08 2:44 ` Linus Torvalds
2011-06-08 3:31 ` Linus Torvalds
2011-06-08 8:31 ` Guillaume Chazarain
2011-06-08 8:28 ` Felipe Balbi
2011-06-08 9:04 ` Alan Cox
2011-06-02 10:03 ` tty vs workqueue oddities Alan Cox
2011-06-03 10:23 tty breakage in X (Was: tty vs workqueue oddities) Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTim6VsynZHLagcu9Xo3EjsUz=54dYA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=balbi@ti.com \
--cc=benh@kernel.crashing.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®