From: Mike Frysinger <vapier@gentoo.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org,
uclinux-dist-devel@blackfin.uclinux.org,
Liam Girdwood <lrg@ti.com>
Subject: Re: [Device-drivers-devel] [alsa-devel] [PATCH 2/3] ASoC: Blackfin: Add bf5xx-adau1701 machine driver
Date: Fri, 10 Jun 2011 13:47:34 -0400 [thread overview]
Message-ID: <BANLkTimBJbkYJnU5vgmo+a5eerRroE1uBg@mail.gmail.com> (raw)
In-Reply-To: <20110610173004.GJ26441@sirena.org.uk>
On Fri, Jun 10, 2011 at 13:30, Mark Brown wrote:
> On Fri, Jun 10, 2011 at 07:18:50PM +0200, Lars-Peter Clausen wrote:
>> Add a machine driver to support the ADAU1701 SigmaDSP processors on
>> Analog Devices BF5XX evaluation boards.
>
> So, I keep on complaining about the way these drivers are just generic
> to any random Blackfin plus CODEC combination rather than being board
> specific. It'd be good if we could improve this, even adding something
> into the driver name to make it clear these are for the EVB would help.
i know you keep complaining, but i honestly dont understand why this
is undesirable. connecting a codec to a Blackfin is pretty much
always the same. you pick a SPORT # and that's about it.
the spi cs and i2c address could differ (so maybe make that a field
for the platform resources), but otherwise i dont see why people
should have to copy & paste the same code to change all of 4 bytes.
-mike
next prev parent reply other threads:[~2011-06-10 17:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 17:18 [PATCH 1/3] ASoC: Add ADAU1701 codec driver Lars-Peter Clausen
2011-06-10 17:18 ` [PATCH 2/3] ASoC: Blackfin: Add bf5xx-adau1701 machine driver Lars-Peter Clausen
2011-06-10 17:30 ` [alsa-devel] " Mark Brown
2011-06-10 17:47 ` Mike Frysinger [this message]
2011-06-10 18:01 ` [Device-drivers-devel] " Mark Brown
2011-06-10 18:13 ` Mike Frysinger
2011-06-10 18:15 ` Mark Brown
2011-06-10 17:50 ` Lars-Peter Clausen
2011-06-10 18:02 ` Mark Brown
2011-06-10 18:13 ` Lars-Peter Clausen
2011-06-10 18:20 ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 17:18 ` [PATCH 3/3] Blackfin: bf537: Stamp: Register adau1701 codec and ASoC " Lars-Peter Clausen
2011-06-10 17:50 ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 17:27 ` [alsa-devel] [PATCH 1/3] ASoC: Add ADAU1701 codec driver Mark Brown
2011-06-10 17:44 ` Mike Frysinger
2011-06-10 18:07 ` Mark Brown
2011-06-10 18:08 ` Mike Frysinger
2011-06-10 17:43 ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 17:57 ` Lars-Peter Clausen
2011-06-10 18:08 ` Mike Frysinger
2011-06-10 18:15 ` Mike Frysinger
2011-06-10 18:22 ` Lars-Peter Clausen
2011-06-10 18:28 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimBJbkYJnU5vgmo+a5eerRroE1uBg@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®