mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Smith <viscous.liquid@gmail.com>
To: Fred Matthews <fredmm@hotmail.co.uk>
Cc: Mohammed Shafi <shafi.wireless@gmail.com>,
	ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, ath9k-devel@lists.ath9k
Subject: Re: [ath9k-devel] Patching ath9k/mac80211 to change MAC layer features
Date: Tue, 28 Jun 2011 08:14:30 -0400	[thread overview]
Message-ID: <BANLkTimBVMm34qBWv7bxKwRL17UnLHcazA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimGyAN2MvPsTAYqCo2LcWQO2xjXtA@mail.gmail.com>

On Tue, Jun 28, 2011 at 3:00 AM, Mohammed Shafi
<shafi.wireless@gmail.com> wrote:
> On Mon, Jun 27, 2011 at 11:07 PM, Fred Matthews <fredmm@hotmail.co.uk> wrote:
>> Hi all,
>>
>> Much appreciated Mohammed Shafi, disabling aggregation works when
>> replacing those lines with
>>  sc->sc_flags &= ~SC_OP_TXAGGR;
>>  sc->sc_flags &= ~SC_OP_RXAGGR;
>> only issue is I must always recompile compat-wireless to
>> re-enable/disable it again. I tried to port it using debugfs to be
>> able to enable and disable at runtime but ath9k kept rebooting.
>
> I am not sure we can enable/disable aggregation via debugfs, these
> flags seem are set at initialization and based on this lot of things
> happen in tx-path, initializing TID structure, ampdu action, rate
> control  etc.
>

The project I am on we have to deal with a situation where we change
the hardware environment and thus have to change some of the
initialization parameters. Obviously the environment is a little
unique, but I believe this should work for you. Before the changes are
made we do a

                if (sc->nvifs > 0) {
                        printk(KERN_INFO "ath9k:card has an open interface\n");
                        return -EBUSY;
                }

                pdev = to_pci_dev(sc->dev);
                pdev->driver->remove(pdev);

then we make our hardware change and  then do a

                pci_id = pci_match_id(pdev->driver->id_table, pdev);
                err = pdev->driver->probe(pdev, pci_id);

which gives us a re-initialized instance of ath_hw and ath_softc for the radio

Hope this helps!

V/r,
Daniel P. Smith

      reply	other threads:[~2011-06-28 12:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BLU158-w332CD7657F92343D3D2D1C876A0@phx.gbl>
2011-06-19 16:13 ` Fred Matthews
2011-06-20  8:15 ` [ath9k-devel] " Mohammed Shafi
2011-06-27 17:37   ` Fred Matthews
2011-06-28  7:00     ` Mohammed Shafi
2011-06-28 12:14       ` Daniel Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimBVMm34qBWv7bxKwRL17UnLHcazA@mail.gmail.com \
    --to=viscous.liquid@gmail.com \
    --cc=ath9k-devel@lists.ath9k \
    --cc=ath9k-devel@venema.h4ckr.net \
    --cc=fredmm@hotmail.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=shafi.wireless@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®