From: Daniel J Blueman <daniel.blueman@gmail.com>
To: Eric Anholt <eric@anholt.net>
Cc: Dave Airlie <airlied@redhat.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Ben Widawsky <ben@bwidawsk.net>,
Kenneth Graunke <kenneth@whitecape.org>,
Yi Sun <yi.sun@intel.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Mengmeng Meng <mengmeng.meng@intel.com>,
Robert Hooker <sarvatt@ubuntu.com>
Subject: Re: [PATCH 3.0-rc3, v2] i915: Fix gen6 (SNB) GPU stalling
Date: Sat, 18 Jun 2011 02:20:08 +0800 [thread overview]
Message-ID: <BANLkTimKKcW3yfDBF2ahYag+kKvdMaA7Mw@mail.gmail.com> (raw)
In-Reply-To: <87zklgnyj0.fsf@eliezer.anholt.net>
On 18 June 2011 01:44, Eric Anholt <eric@anholt.net> wrote:
> On Sat, 18 Jun 2011 00:42:00 +0800, Daniel J Blueman <daniel.blueman@gmail.com> wrote:
>> Workaround Sandy Bridge GPU stalls by allowing the blitter command streamer
>> to write interrupt state to the Hardware Status Page when a MI_USER_INTERRUPT
>> command is decoded.
>>
>> v1->v2: Moved to prior interrupt handler installation and RMW flags as per
>> feedback.
>
> We shouldn't be RMWing. We're the driver, we're supposed to know what
> we want. I'm backing that bit out, will do another round of testing,
> and send it off.
I still prefer directly setting the mask due to my earlier reasons.
Unmasking in the IRQ preinstall tests good here, so I'll send a v3
patch in the morning.
Thanks,
Daniel
--
Daniel J Blueman
next prev parent reply other threads:[~2011-06-17 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 16:42 Daniel J Blueman
2011-06-17 17:44 ` Eric Anholt
2011-06-17 18:20 ` Daniel J Blueman [this message]
2011-06-17 20:39 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimKKcW3yfDBF2ahYag+kKvdMaA7Mw@mail.gmail.com \
--to=daniel.blueman@gmail.com \
--cc=airlied@redhat.com \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=kenneth@whitecape.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengmeng.meng@intel.com \
--cc=sarvatt@ubuntu.com \
--cc=yi.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®