From: Maxin B John <maxin.john@gmail.com>
To: tim.gardner@canonical.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
airlied@redhat.com, lethal@linux-sh.org, james@albanarts.com,
error27@gmail.com, randy.dunlap@oracle.com
Subject: Re: [PATCH] drivers: video: Remove useless checks
Date: Thu, 26 May 2011 16:31:27 +0100 [thread overview]
Message-ID: <BANLkTimOkpfLSiHp0Dm+jxxtHfA3PSVG-A@mail.gmail.com> (raw)
In-Reply-To: <4DDE58E9.1050307@canonical.com>
Hi,
> IMHO mixing signed and unsigned comparisons like this is just wrong. Its
> unnecessarily complicated and misleading, especially for a device driver.
Yes. I do agree with you.
> Its likely that the reason the fb code got into this situation is because a
> type was changed from signed to unsigned whence long ago, and nobody has
> bothered to clean it up.
Thats possible. Similar useless checks are present in other subsystems
of the kernel as well.
WBR,
Maxin
next prev parent reply other threads:[~2011-05-26 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 18:27 Maxin B John
2011-05-22 8:06 ` Maxin B John
2011-05-25 12:47 ` Tim Gardner
2011-05-26 9:30 ` Maxin B John
2011-05-26 13:43 ` Tim Gardner
2011-05-26 15:31 ` Maxin B John [this message]
2011-06-03 9:29 ` Maxin B John
2011-06-03 20:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimOkpfLSiHp0Dm+jxxtHfA3PSVG-A@mail.gmail.com \
--to=maxin.john@gmail.com \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=james@albanarts.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome