From: Dave Young <hidave.darkstar@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
ebiederm@xmission.com
Subject: Re: + sysctl-add-proc_dointvec_unsigned-handler-update.patch added to -mm tree
Date: Fri, 10 Jun 2011 17:51:50 +0800 [thread overview]
Message-ID: <BANLkTimPT-LEsEs34dvPZNbVKnwCT8ck6g@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikAvnam2WNTBMj_J5yBHrxJxSjLuw@mail.gmail.com>
On Fri, Jun 10, 2011 at 1:19 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Wed, Jun 8, 2011 at 11:45 PM, <akpm@linux-foundation.org> wrote:
>> --- a/kernel/sysctl.c~sysctl-add-proc_dointvec_unsigned-handler-update
>> +++ a/kernel/sysctl.c
>> @@ -2515,6 +2515,7 @@ int proc_dointvec_unsigned(struct ctl_ta
>> {
>> struct do_proc_dointvec_minmax_conv_param param = {
>> .min = &zero,
>> + .max = (int *) table->extra2,
>> };
>> return do_proc_dointvec(table, write, buffer, lenp, ppos,
>> do_proc_dointvec_minmax_conv, ¶m);
>
> This is still buggybecause "zero" is only 1 variable and max can be an array.
> Sysctl boundary comparisons are done element-by-element.
Where's the array use case?
--
Regards
dave
next prev parent reply other threads:[~2011-06-10 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201106082045.p58Kjwmd027729@imap1.linux-foundation.org>
2011-06-09 17:19 ` Alexey Dobriyan
2011-06-10 9:51 ` Dave Young [this message]
2011-08-18 21:52 ` Andrew Morton
2011-08-19 1:10 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimPT-LEsEs34dvPZNbVKnwCT8ck6g@mail.gmail.com \
--to=hidave.darkstar@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®