mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Parisc List <linux-parisc@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Linux/m68k" <linux-m68k@vger.kernel.org>
Subject: Re: [GIT PULL] parisc fixes for 2.6.39-rc5
Date: Wed, 27 Apr 2011 22:36:40 +0200	[thread overview]
Message-ID: <BANLkTimPzRuGqjxXqe7tn-C52suTVE9+ig@mail.gmail.com> (raw)
In-Reply-To: <1303935518.2583.27.camel@mulgrave.site>

On Wed, Apr 27, 2011 at 22:18, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> These two fixes contain the agreed fix for our slub panic (agreed with
> the mm folks that we'll define SLUB broken in the !NUMA && DISCONTIGMEM
> case, which should fix m86k as well) and another buglet that turned up
> examining the parisc discontigmem code.

Do we still need to mark SLUB broken?
On m68k, the issue seems to have been fixed by setting the N_NORMAL_MEMORY flag
(pull request scheduled after one more linux-next build cycle).

Or do you plan to unmark it broken once every affected arch sets the
N_NORMAL_MEMORY flag?

> The patches are here:
>
> master.kernel.org:/pub/scm/linux/kernel/git/jejb/parisc-2.6.git#fixes
>
> The short changelog is:
>
> David Rientjes (1):
>      [PARISC] set memory ranges in N_NORMAL_MEMORY when onlined
>
> James Bottomley (1):
>      [PARISC] slub: fix panic with DISCONTIGMEM
>
> The diffstat is:
>
>  arch/parisc/mm/init.c |    4 +++-
>  init/Kconfig          |    1 +
>  2 files changed, 4 insertions(+), 1 deletions(-)
>
> And the full diff are below.
>
> James
>
> ---
>
> diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c
> index b7ed8d7..b1d1262 100644
> --- a/arch/parisc/mm/init.c
> +++ b/arch/parisc/mm/init.c
> @@ -266,8 +266,10 @@ static void __init setup_bootmem(void)
>        }
>        memset(pfnnid_map, 0xff, sizeof(pfnnid_map));
>
> -       for (i = 0; i < npmem_ranges; i++)
> +       for (i = 0; i < npmem_ranges; i++) {
> +               node_set_state(i, N_NORMAL_MEMORY);
>                node_set_online(i);
> +       }
>  #endif
>
>        /*
> diff --git a/init/Kconfig b/init/Kconfig
> index 56240e7..a7ad8fb 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1226,6 +1226,7 @@ config SLAB
>          per cpu and per node queues.
>
>  config SLUB
> +       depends on BROKEN || NUMA || !DISCONTIGMEM
>        bool "SLUB (Unqueued Allocator)"
>        help
>           SLUB is a slab allocator that minimizes cache line usage

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2011-04-27 20:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27 20:18 James Bottomley
2011-04-27 20:36 ` Geert Uytterhoeven [this message]
2011-04-27 20:55   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimPzRuGqjxXqe7tn-C52suTVE9+ig@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®