From: Andrei Warkentin <andreiw@motorola.com>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, hjanssen@microsoft.com,
haiyangz@microsoft.com
Subject: Re: [PATCH] HV SynthHID: Fix compile error.
Date: Mon, 11 Apr 2011 15:14:33 -0500 [thread overview]
Message-ID: <BANLkTimUjS2cWkSkKm4gZzwQigmHWhN+=A@mail.gmail.com> (raw)
In-Reply-To: <20110411192733.GB23059@suse.de>
On Mon, Apr 11, 2011 at 2:27 PM, Greg KH <gregkh@suse.de> wrote:
> On Mon, Apr 11, 2011 at 03:01:32PM -0500, Andrei Warkentin wrote:
>> Missing include for <asm/delay.h>
>>
>> Signed-off-by: Andrei Warkentin <andreiw@motorola.com>
>> ---
>> drivers/staging/hv/hv_mouse.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
>> index 50147f8..c5020c0 100644
>> --- a/drivers/staging/hv/hv_mouse.c
>> +++ b/drivers/staging/hv/hv_mouse.c
>> @@ -23,6 +23,7 @@
>> #include <linux/hiddev.h>
>> #include <linux/pci.h>
>> #include <linux/dmi.h>
>> +#include <asm/delay.h>
>
> Never include "<asm/" include files if at all possible.
>
Oops, alright, will do.
> Anyway, this should already be fixed in Linus's tree, right?
>
Sorry no clue, if so, thanks ahead. I was testing something else in
SD/MMC-land and wanted to make sure it compiled cleanly on x86/x64.
A
prev parent reply other threads:[~2011-04-11 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 20:01 Compile errors for SynthHid Andrei Warkentin
2011-04-11 20:01 ` [PATCH] HV SynthHID: Fix compile error Andrei Warkentin
2011-04-11 19:27 ` Greg KH
2011-04-11 20:14 ` Andrei Warkentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimUjS2cWkSkKm4gZzwQigmHWhN+=A@mail.gmail.com' \
--to=andreiw@motorola.com \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®