From: Hillf Danton <dhillf@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Mike Galbraith <efault@gmx.de>,
Yong Zhang <yong.zhang0@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Subject: [PATCH] sched: fix rt_nr_migratory corruption raised in push_rt_task()
Date: Mon, 30 May 2011 21:39:50 +0800 [thread overview]
Message-ID: <BANLkTimfOsJ91_PJdB5-H02EGS0S5eJ5cA@mail.gmail.com> (raw)
When pushing, if a pushable task could not be pushed, it is dequeued with no
updating the rt_nr_migratory element of RT run-queue, then rt_nr_migratory is
corrupted, which is fixed by removing the dequeue operation.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
kernel/sched_rt.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index 88725c9..496e06a 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -1378,6 +1378,7 @@ static int push_rt_task(struct rq *rq)
{
struct task_struct *next_task;
struct rq *lowest_rq;
+ int ret = 1;
if (!rq->rt.overloaded)
return 0;
@@ -1425,7 +1426,7 @@ retry:
* since the other cpus will pull from us when they
* are ready.
*/
- dequeue_pushable_task(rq, next_task);
+ ret = 0;
goto out;
}
@@ -1452,7 +1453,7 @@ retry:
out:
put_task_struct(next_task);
- return 1;
+ return ret;
}
static void push_rt_tasks(struct rq *rq)
next reply other threads:[~2011-05-30 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 13:39 Hillf Danton [this message]
2011-05-31 7:36 ` Mike Galbraith
2011-05-31 13:56 ` Hillf Danton
2011-05-31 15:08 ` Steven Rostedt
2011-06-01 2:14 ` [PATCH] sched, rt: fix rq->rt.pushable_tasks bug " Mike Galbraith
2011-06-01 2:29 ` Mike Galbraith
2011-08-14 16:02 ` [tip:sched/core] sched, rt: Fix " tip-bot for Hillf Danton
2011-06-01 2:21 ` [PATCH] sched: fix rt_nr_migratory corruption raised " Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimfOsJ91_PJdB5-H02EGS0S5eJ5cA@mail.gmail.com \
--to=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome