From: saeed bishara <saeed.bishara@gmail.com>
To: Joe Perches <joe@perches.com>, Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, Mikael Pettersson <mikpe@it.uu.se>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ata: Add and use ata_print_version_once
Date: Tue, 26 Apr 2011 10:59:14 +0300 [thread overview]
Message-ID: <BANLkTimsuTYRn0+_Ap+W_a9d6X=zFgngfQ@mail.gmail.com> (raw)
In-Reply-To: <1303073786.31723.14.camel@Joe-Laptop>
On Sun, Apr 17, 2011 at 11:56 PM, Joe Perches <joe@perches.com> wrote:
> On Sun, 2011-04-17 at 13:45 +0300, saeed bishara wrote:
>> On Sat, Apr 16, 2011 at 1:52 AM, Joe Perches <joe@perches.com> wrote:
>> > Use a single mechanism to show driver version.
>> > Reduces text a tiny bit too.
>> > Remove uses of static int printed_version
>> > Add and use ata_print_version(const struct device *, const char *ver)
>> > and ata_print_version_once.
>> any idea why we really need this driver version for in-kernel drivers?
>> isn't the kernel version good enough?
>
> Some think it useful to see what module
> version is linked against the kernel.
1. I looked at 3-4 drivers, and found that it didn't modified its
version since at least 3 years, so it doesn't look to me that this
version is maintained properly.
2. anyway, if you still think this feature is needed, then maybe you
should consider making it generic one, this is not ata specific
feature.
saeed
next prev parent reply other threads:[~2011-04-26 7:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 22:51 [PATCH 0/4] ata: Logging message cleanups Joe Perches
2011-04-15 22:51 ` [PATCH 1/4] ata: Convert dev_printk(KERN_<LEVEL> to dev_<level>( Joe Perches
2011-04-15 22:51 ` [PATCH 2/4] ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>( Joe Perches
2011-04-15 22:52 ` [PATCH 3/4] ata: Add and use ata_print_version_once Joe Perches
2011-04-17 10:45 ` saeed bishara
2011-04-17 20:56 ` Joe Perches
2011-04-26 7:59 ` saeed bishara [this message]
2011-04-15 22:52 ` [PATCH 4/4] ata: sata_via: Use dev_dbg Joe Perches
2011-05-18 15:12 ` [PATCH 0/4] ata: Logging message cleanups Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimsuTYRn0+_Ap+W_a9d6X=zFgngfQ@mail.gmail.com' \
--to=saeed.bishara@gmail.com \
--cc=jgarzik@pobox.com \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®