mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Parag Warudkar <parag.lkml@gmail.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Ingo Molnar <mingo@elte.hu>, Dmitry Torokhov <dtor@mail.ru>,
	linux-kernel@vger.kernel.org
Subject: Re: Resume Issues :Exec of NX page, Synaptics Botchup
Date: Sun, 22 May 2011 16:43:07 -0700	[thread overview]
Message-ID: <BANLkTimt0ozTCSarTVwkOpvgLoW-pizMvA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1105221817100.1868@natty-nar>

On Sun, May 22, 2011 at 3:22 PM, Parag Warudkar <parag.lkml@gmail.com> wrote:
>
> Now I get a different call trace for the same NX error. (And Synaptics is
> completely dead this time - not attributable to the patch, it was dumb
> luck perhaps that it wored last time.)

Just because I'm crazy, can you double-check that you applied my patch
and booted the right kernel?

Because that NX error *really* looks like the call to setup_smep(),
and the eip still very much looks like something jumped to the
"__init" region, not the "__cpuinit" region.

That backtrace really still looks like the same thing.

Oh, and you should do

-static int disable_smep __initdata;
+static int disable_smep __cpuinitdata;

too, I guess. Not that it should matter for this particular oops.

                 Linus

  parent reply	other threads:[~2011-05-22 23:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22 21:36 Parag Warudkar
2011-05-22 21:56 ` Linus Torvalds
2011-05-22 22:22   ` Parag Warudkar
2011-05-22 22:41     ` Rafael J. Wysocki
2011-05-23  2:49       ` Yu, Fenghua
2011-05-23 21:22         ` Rafael J. Wysocki
2011-05-23 21:31           ` Yu, Fenghua
2011-05-22 23:43     ` Linus Torvalds [this message]
2011-05-23  3:04       ` Parag Warudkar
2011-05-23 16:38         ` Dmitry Torokhov
2011-05-23 10:10       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimt0ozTCSarTVwkOpvgLoW-pizMvA@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=dtor@mail.ru \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=parag.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®