mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hillf Danton <dhillf@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH] sched: try to rewrite tg_has_rt_tasks()
Date: Sat, 23 Apr 2011 21:39:40 +0800	[thread overview]
Message-ID: <BANLkTimyN49J0UTo69Rabppeow9Fz-LcfQ@mail.gmail.com> (raw)

It is reshuffled not based upon scanning the list of existing threads
but upon the relevant info carried by the input task group. Compared
with the original, it is simpler, and nothing important is missed.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
---

--- a/kernel/sched.c	2011-03-30 03:09:48.000000000 +0800
+++ b/kernel/sched.c	2011-04-23 21:48:14.000000000 +0800
@@ -8756,13 +8756,11 @@ static unsigned long to_ratio(u64 period
 /* Must be called with tasklist_lock held */
 static inline int tg_has_rt_tasks(struct task_group *tg)
 {
-	struct task_struct *g, *p;
-
-	do_each_thread(g, p) {
-		if (rt_task(p) && rt_rq_of_se(&p->rt)->tg == tg)
+	int cpu;
+	for_each_online_cpu(cpu) {
+		if (tg->rt_rq[cpu]->rt_nr_running != 0)
 			return 1;
-	} while_each_thread(g, p);
-
+	}
 	return 0;
 }

             reply	other threads:[~2011-04-23 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-23 13:39 Hillf Danton [this message]
2011-04-23 14:11 ` Yong Zhang
2011-04-23 14:19   ` Hillf Danton
2011-04-23 14:31     ` Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimyN49J0UTo69Rabppeow9Fz-LcfQ@mail.gmail.com \
    --to=dhillf@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®