mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Justin TerAvest <teravest@google.com>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Chad Talbott <ctalbott@google.com>
Subject: Re: Why do we use cpu nice priority for ioprio?
Date: Wed, 30 Mar 2011 11:23:45 -0700	[thread overview]
Message-ID: <BANLkTimzt7QhBdayBpB3dRSOSY3G3VCfcw@mail.gmail.com> (raw)
In-Reply-To: <4D8C48B6.6050300@fusionio.com>

On Fri, Mar 25, 2011 at 12:48 AM, Jens Axboe <jaxboe@fusionio.com> wrote:
> On 2011-03-25 03:38, Justin TerAvest wrote:
>> It's not clear why the cpu nice value should be mapped to the ioprio
>> for a task when none is picked.
>>
>> Internally, at cfq_init_prio_data(), we just set:
>>               ioprio = IOPRIO_NORM;
>>               ioprio_class = IOPRIO_CLASS_BE;
>> if ioprio_class is IOPRIO_CLASS_NONE.
>>
>>
>> The problem is that  today, SCHED_RR and SCHED_FIFO threads
>> automatically get bumped up to RT class. This all happens behind the
>> curtains and the io_class of the thread is still shown as NONE with
>> sys_ioprio_get(). What's the motivation behind this promotion of
>> ioprio class?
>
> It was decided back in the day when io priorities were introduced. I
> still think it's a good idea.

This is the part I'm especially curious about. If we're managing the
resources separately,
why should be be adjusting io_class based on the nice value?

> You could argue that auto-bumping up to
> IOPRIO_CLASS_RT is a bit heavy handed. But is it really that different
> from the CPU scheduling?

But why do auto bumping at all? Is this for convenience, so users only
have to nice their tasks?

>
> So, from memory, the difference between RR and FIFO on the CPU
> scheduling side is that one of them will relingiush the CPU for a brief
> period once in a while. Correct? That does not happen for
> IOPRIO_CLASS_RT. So at least from that perspective, it's not a complete
> match and might be a cause for concern.
>
> --
> Jens Axboe
>
>

  reply	other threads:[~2011-03-30 18:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25  2:38 Justin TerAvest
2011-03-25  7:48 ` Jens Axboe
2011-03-30 18:23   ` Justin TerAvest [this message]
2011-03-30 18:34     ` Vivek Goyal
2011-03-31  3:59       ` Justin TerAvest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimzt7QhBdayBpB3dRSOSY3G3VCfcw@mail.gmail.com \
    --to=teravest@google.com \
    --cc=ctalbott@google.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome