From: Ohad Ben-Cohen <ohad@wizery.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, lee.jones@linaro.org,
patches@linaro.org, linus.walleij@stericsson.com
Subject: Re: [PATCH 1/2] ux500: Adding support for u8500 Hsem functionality V2
Date: Wed, 13 Apr 2011 11:16:47 +0300 [thread overview]
Message-ID: <BANLkTinGt1wey0ofLRUVzS4Ru==OLvChTQ@mail.gmail.com> (raw)
In-Reply-To: <201104121946.01618.arnd@arndb.de>
On Tue, Apr 12, 2011 at 8:46 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> When you do that, this can be a single allocation.
>
> Thinking about it some more, it may actually be worthwhile to still improve
> the API here: I think the owner field should be part of the operations structure,
> because it is constant. It would also be nice to have a "private" pointer
> in struct hwspinlock, so you don't need to wrap it if you don't want to.
These are good improvements, part of which I planned to do so too
(especially to take out the dev, ops and owner fields into a dedicated
structure, and have all the hwspinlock instances, which belong to that
block, point at it).
By introducing a "private" pointer, and removing the platform-specific
wrapping around it, we can also get rid of the 'id' field, and induce
it with a simple pointers arithmetic (namely, id = pointer of instance
- array base address).
prev parent reply other threads:[~2011-04-13 8:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 15:24 mathieu.poirier
2011-04-12 13:44 ` Ohad Ben-Cohen
2011-04-12 16:53 ` Mathieu Poirier
2011-04-12 17:46 ` Arnd Bergmann
2011-04-12 19:13 ` Mathieu Poirier
2011-04-13 8:45 ` Ohad Ben-Cohen
2011-04-17 20:39 ` Arnd Bergmann
2011-04-19 16:06 ` Mathieu Poirier
2011-04-19 16:10 ` Arnd Bergmann
2011-09-05 21:09 ` Ohad Ben-Cohen
2011-09-06 7:15 ` Linus Walleij
2011-09-06 7:27 ` Ohad Ben-Cohen
2011-04-13 8:16 ` Ohad Ben-Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinGt1wey0ofLRUVzS4Ru==OLvChTQ@mail.gmail.com' \
--to=ohad@wizery.com \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®