From: Jeffrey Brown <jeffbrown@android.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: rydberg@euromail.se, djkurtz@google.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] input: evdev: Indicate buffer overrun with SYN_DROPPED.
Date: Mon, 4 Apr 2011 14:52:19 -0700 [thread overview]
Message-ID: <BANLkTineFm2WvtHi6pL6f3UOhPcpiRdKQA@mail.gmail.com> (raw)
In-Reply-To: <20110404213338.GB984@core.coreip.homeip.net>
Hi Dmitry,
On Mon, Apr 4, 2011 at 2:33 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Fri, Apr 01, 2011 at 11:54:18PM -0700, Jeff Brown wrote:
>> + * When the client buffer is full, drain the buffer and enqueue a
>> + * SYN_DROPPED event to let the client know that events were dropped
>> + * and the last packet was incomplete. We then consume all remaining
>> + * events from the dropped packet until the next packet begins.
>
> I do not think we (kernel) should be doing this. Clients should take
> care and not allow overruns but if they happen the pain should be on the
> client to restore the context. It has to query the device to get its
> current state and it can drop the events till next sync as well.
That's fine. We should document SYN_DROPPED and mention that the
client should wait until after the next SYN_REPORT to get back in
sync.
> Therefore I intend to apply the patch in the form below.
Looks good to me. It's more like my original patch.
Jeff.
next prev parent reply other threads:[~2011-04-04 21:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 6:54 [PATCH v2 1/4] input: Set default events per packet Jeff Brown
2011-04-02 6:54 ` [PATCH v2 2/4] hid: hid-input: Remove obsolete default events per packet setting Jeff Brown
2011-04-05 12:20 ` Henrik Rydberg
2011-04-02 6:54 ` [PATCH v2 3/4] input: evdev: Indicate buffer overrun with SYN_DROPPED Jeff Brown
2011-04-04 21:33 ` Dmitry Torokhov
2011-04-04 21:52 ` Jeffrey Brown [this message]
2011-04-05 11:41 ` Henrik Rydberg
2011-04-02 6:54 ` [PATCH v2 4/4] input: evdev: Make device readable only when it contains a complete packet Jeff Brown
2011-04-04 21:36 ` Dmitry Torokhov
2011-04-04 22:16 ` Jeffrey Brown
2011-04-04 22:46 ` Dmitry Torokhov
2011-04-05 0:34 ` Jeffrey Brown
2011-04-05 12:03 ` Henrik Rydberg
2011-04-05 16:32 ` Dmitry Torokhov
2011-04-05 16:38 ` Dmitry Torokhov
2011-04-11 20:15 ` Jeffrey Brown
2011-04-05 12:16 ` [PATCH v2 1/4] input: Set default events per packet Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTineFm2WvtHi6pL6f3UOhPcpiRdKQA@mail.gmail.com \
--to=jeffbrown@android.com \
--cc=djkurtz@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®