From: Grant Likely <grant.likely@secretlab.ca>
To: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: Michal Simek <monstr@monstr.eu>,
Wolfram Sang <w.sang@pengutronix.de>,
devicetree-discuss@lists.ozlabs.org, john.williams@petalogix.com,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH v4] uio/pdrv_genirq: Add OF support
Date: Wed, 4 May 2011 14:29:46 -0600 [thread overview]
Message-ID: <BANLkTing9GPbsur2vpRtpnDcxLUkrDFZmQ@mail.gmail.com> (raw)
In-Reply-To: <20110504194730.GA2820@local>
On Wed, May 4, 2011 at 1:47 PM, Hans J. Koch <hjk@hansjkoch.de> wrote:
> On Wed, May 04, 2011 at 03:21:55PM +0200, Michal Simek wrote:
>> Hans J. Koch wrote:
>> >On Tue, May 03, 2011 at 10:34:12PM +0200, Wolfram Sang wrote:
>> >>On Mon, May 02, 2011 at 08:51:55AM +0200, Michal Simek wrote:
>> >>>Adding OF binding to genirq.
>> >>>Version string is setup to the "devicetree".
>> >>>
>> >>>Compatible string is not setup for now but you can add your
>> >>>custom compatible string to uio_of_genirq_match structure.
>> >>>
>> >>>For example with "vendor,device" compatible string:
>> >>>static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
>> >>> { .compatible = "vendor,device", },
>> >>> { /* empty for now */ },
>> >>>};
>> >>>
>> >>>Signed-off-by: Michal Simek <monstr@monstr.eu>
>> >>[...]
>> >>
>> >>>+ /* alloc uioinfo for one device */
>> >>>+ uioinfo = kzalloc(sizeof(*uioinfo), GFP_KERNEL);
>> >>kfree in remove?
>> >
>> >Oh yes. Missed that one. It should probably look like the "bad0" case in probe().
>>
>> Yes, freeing uioinfo in uio_pdrv_genirq_remove make sense for CONFIG_OF.
>>
>> Please correct me if I am wrong dev.of_node is not NULL for OF. I
>> think yes that's why I would prefer to use this construct instead of
>> #ifdef CONFIG_OF.
>>
>> if (pdev->dev.of_node)
>> kfree(pdev->dev.platform_data);
>
> Huh? You didn't allocate platform_data, so you shouldn't free it.
> It's uioinfo you allocated.
*never* set or modify the pdev->dev.platform_data pointer from a
device driver. If the data needs to be modified, or a new structure
allocated, then rework the driver to store it in it's private data
structure. platform_data must be considered immutable by drivers.
Otherwise you'll break unbindng and rebinding device drivers.
g.
next prev parent reply other threads:[~2011-05-04 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 6:51 Michal Simek
2011-05-03 19:57 ` Hans J. Koch
2011-05-03 20:34 ` Wolfram Sang
2011-05-03 22:14 ` Hans J. Koch
2011-05-04 13:21 ` Michal Simek
2011-05-04 19:47 ` Hans J. Koch
2011-05-04 20:29 ` Grant Likely [this message]
2011-05-05 5:26 ` Michal Simek
2011-05-06 0:55 ` Hans J. Koch
2011-05-04 13:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTing9GPbsur2vpRtpnDcxLUkrDFZmQ@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=hjk@hansjkoch.de \
--cc=john.williams@petalogix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®