From: "Matthew L. Creech" <mlcreech@gmail.com>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@nokia.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] fix-up free space earlier in mount_ubifs()
Date: Tue, 31 May 2011 10:43:55 -0400 [thread overview]
Message-ID: <BANLkTinu7dX5Tfhs0ak0BEfc212mpJKb+w@mail.gmail.com> (raw)
In-Reply-To: <cover.1306780983.git.bengardiner@nanometrics.ca>
On Mon, May 30, 2011 at 2:56 PM, Ben Gardiner
<bengardiner@nanometrics.ca> wrote:
> In testing Mattew Creech's free-space-fixup flag series I found that was unable
> to boot a da850evm which had flashed to it's NAND a ubinized image containing a
> UBIFS that has the free-space-fixup flag set.
>
> The cause of the problem was found to be the call to ubifs_write_master() from
> mount_ubifs() as is evidenced the backtrace produced by the assertion
> introduced in the first patch of this series; where the assertion introduced is
> that c->space_fixup is false when ubifs_write_node() is called.
>
Interesting - so the problem is that if ubifs_read_master() resizes
the master node, a subsequent attempt to read the first (c->mst_offs +
c->mst_node_alsz) bytes from the master LEB fails?
I wonder why this is the case when free-space fixup is enabled, and
not otherwise? The -EBADMSG seems to imply that this is the original
problem that the fix-up is intended to solve - i.e. the master node
has empty pages with non-empty OOB values, and writing to them results
in a bogus ECC.
Do you happen to know if the same thing occurs when you uncleanly
reboot (so that recovery is needed on the next boot)? It looks like
ubifs_recover_master_node() reads the same data that
fixup_leb_free_space() does, so I'd expect it to fail similarly if
that's what's happening, regardless of whether fix-up is performed or
not.
Just trying to fully understand the error. :) That aside, this patch
set makes sense to me. Thanks!
--
Matthew L. Creech
next prev parent reply other threads:[~2011-05-31 14:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 18:56 Ben Gardiner
2011-05-30 18:56 ` [PATCH 1/3] UBIFS: assert no fixup when writing a node Ben Gardiner
2011-06-01 10:03 ` Artem Bityutskiy
2011-05-30 18:56 ` [PATCH 2/3] UBIFS: intialize the LPT earlier Ben Gardiner
2011-06-01 10:06 ` Artem Bityutskiy
2011-05-30 18:56 ` [PATCH 3/3] UBIFS: fix-up free space earlier Ben Gardiner
2011-06-01 10:16 ` Artem Bityutskiy
2011-06-01 14:53 ` [PATCH] UBIFS: fixup merged 'UBIFS: fix-up free space earlier' Ben Gardiner
2011-06-01 15:03 ` Artem Bityutskiy
2011-06-01 15:14 ` Artem Bityutskiy
2011-06-01 15:28 ` Ben Gardiner
2011-05-31 14:43 ` Matthew L. Creech [this message]
2011-05-31 14:52 ` [PATCH 0/3] fix-up free space earlier in mount_ubifs() Ben Gardiner
2011-05-31 15:22 ` Matthew L. Creech
2011-06-01 10:20 ` Artem Bityutskiy
2011-05-31 15:37 ` Ben Gardiner
2011-06-01 10:19 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinu7dX5Tfhs0ak0BEfc212mpJKb+w@mail.gmail.com \
--to=mlcreech@gmail.com \
--cc=adrian.hunter@nokia.com \
--cc=bengardiner@nanometrics.ca \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®