From: Linus Walleij <linus.walleij@linaro.org>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: linux-arm-kernel@lists.infradead.org, rpurdie@rpsys.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] mach-realview: retire custom LED code
Date: Sun, 26 Jun 2011 13:10:48 +0200 [thread overview]
Message-ID: <BANLkTinx0uFE-ODhTcpsJdE5KSq_C8aB6g@mail.gmail.com> (raw)
In-Reply-To: <1309039804-659-4-git-send-email-bryan.wu@canonical.com>
2011/6/26 Bryan Wu <bryan.wu@canonical.com>:
> This replaces the custom LED trigger code in mach-realview with
> some overarching platform code for the plat-versatile family that
> will lock down LEDs 2 thru 5 for CPU activity indication. The
> day we have 8 core ARM systems the plat-versatile code will have
> to become more elaborate.
>
> Tested on RealView PB11MPCore by invoking four different CPU
> hogs (yes > /dev/null&) and see the LEDs go on one at a time.
> They all go off as the hogs are killed. Tested on the PB1176
> as well - just one activity led (led 2) goes on and off with
> CPU activity.
>
> (bryan.wu@canonical.com: use ledtrig-cpu instead of ledtrig-arm-cpu)
>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
This is good, especially the KConfig fixups, but also include Pawel Moll's
Acked-by on these patches.
Linus Walleij
next prev parent reply other threads:[~2011-06-26 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-25 22:10 [PATCH 0/4] Introduce a led trigger for CPU activity Bryan Wu
2011-06-25 22:10 ` [PATCH 1/4] leds: create a " Bryan Wu
2011-06-25 22:10 ` [PATCH 2/4] ARM: use new LEDS CPU trigger stub to replace old one Bryan Wu
2011-06-26 11:08 ` Linus Walleij
2011-06-27 6:00 ` Bryan Wu
2011-06-25 22:10 ` [PATCH 3/4] mach-realview: retire custom LED code Bryan Wu
2011-06-26 11:10 ` Linus Walleij [this message]
2011-06-25 22:10 ` [PATCH 4/4] mach-versatile: " Bryan Wu
2011-06-26 11:02 ` [PATCH 0/4] Introduce a led trigger for CPU activity Linus Walleij
2011-06-27 5:59 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinx0uFE-ODhTcpsJdE5KSq_C8aB6g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bryan.wu@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®