mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jing Min Zhao" <zhaojingmin@hotmail.com>
To: "Patrick McHardy" <kaber@trash.net>, "Adrian Bunk" <bunk@stusta.de>
Cc: <netdev@vger.kernel.org>, <zhaojingmin@users.sourceforge.net>,
	<netfilter-devel@lists.netfilter.org>,
	"Jing Min Zhao" <zhaojignmin@hotmail.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: Two comments on the H.323 conntrack/NAT helper
Date: Thu, 23 Mar 2006 21:40:42 -0500	[thread overview]
Message-ID: <BAY109-DAV145F135DA57D0E819D208AB3DF0@phx.gbl> (raw)
In-Reply-To: <44235324.3080607@trash.net>


----- Original Message ----- 
From: "Patrick McHardy" <kaber@trash.net>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: <netdev@vger.kernel.org>; <zhaojingmin@users.sourceforge.net>; 
<netfilter-devel@lists.netfilter.org>; "Jing Min Zhao" 
<zhaojignmin@hotmail.com>; <linux-kernel@vger.kernel.org>
Sent: Thursday, March 23, 2006 9:02 PM
Subject: Re: Two comments on the H.323 conntrack/NAT helper


> [The hotmail address of the author doesn't work, CCed sourceforge-address]
>
> Adrian Bunk wrote:
>> Two comments on the H.323 conntrack/NAT helper:
>> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
>>   please move them to a header file
>
> Their ugliness is because of the current API, which cleaned up
> quite a lot of the surrounding code, but requires this ugliness
> from each helper. I would like to keep them visible as a reminder
> that a cleaner solution is wanted, but moving them to header
> files certainly sound like a good idea to eliminate the risk
> of prototype conflicts. But please do this for all helpers
> at once.
>
>> - is there a reason for not using EXPORT_SYMBOL_GPL?
>
> I would prefer that too.
>
>

Sure, I'll do that.

Thanks

Jing Min Zhao 

  reply	other threads:[~2006-03-24  2:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-24  0:13 Adrian Bunk
2006-03-24  2:02 ` Patrick McHardy
2006-03-24  2:40   ` Jing Min Zhao [this message]
2006-03-24 19:02   ` Jing Min Zhao
2006-03-24  2:34 ` Jing Min Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BAY109-DAV145F135DA57D0E819D208AB3DF0@phx.gbl \
    --to=zhaojingmin@hotmail.com \
    --cc=bunk@stusta.de \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=zhaojignmin@hotmail.com \
    --cc=zhaojingmin@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®