From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422976AbWCXCeN (ORCPT ); Thu, 23 Mar 2006 21:34:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932640AbWCXCeN (ORCPT ); Thu, 23 Mar 2006 21:34:13 -0500 Received: from bay0-omc1-s34.bay0.hotmail.com ([65.54.246.106]:24285 "EHLO bay0-omc1-s34.bay0.hotmail.com") by vger.kernel.org with ESMTP id S932637AbWCXCeM (ORCPT ); Thu, 23 Mar 2006 21:34:12 -0500 Message-ID: X-Originating-IP: [72.60.172.10] X-Originating-Email: [zhaojingmin@hotmail.com] From: "Jing Min Zhao" To: "Adrian Bunk" , "Jing Min Zhao" Cc: , , References: <20060324001307.GO22727@stusta.de> Subject: Re: Two comments on the H.323 conntrack/NAT helper Date: Thu, 23 Mar 2006 21:34:02 -0500 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2180 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 X-OriginalArrivalTime: 24 Mar 2006 02:34:11.0174 (UTC) FILETIME=[6EE9E060:01C64EEB] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- From: "Adrian Bunk" To: "Jing Min Zhao" Cc: ; ; Sent: Thursday, March 23, 2006 7:13 PM Subject: Two comments on the H.323 conntrack/NAT helper > Two comments on the H.323 conntrack/NAT helper: Thank you for your advice. > - the function prototypes in ip_nat_helper_h323.c are _ugly_, > please move them to a header file Correct, I'll do that. > - is there a reason for not using EXPORT_SYMBOL_GPL? > No, I just forgot it. I'll change this too. > cu Hope I can get more advice from you. > Adrian > > -- > > "Is there not promise of rain?" Ling Tan asked suddenly out > of the darkness. There had been need of rain for many days. > "Only a promise," Lao Er said. > Pearl S. Buck - Dragon Seed > That's Hepburn :-) > >