mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexey Shinkin" <alexshinkin@hotmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: questions on wait_event ...
Date: Fri, 23 Dec 2005 06:51:04 +0600	[thread overview]
Message-ID: <BAY16-F8E0161EA0C4B79180F698AF330@phx.gbl> (raw)
In-Reply-To: <43AB41D9.6070600@shaw.ca>



>Alexey Shinkin wrote:
>>Hi , all !
>>Could anyone please clarify one thing in that old well known
>>wait_event_... code (taken from 2.6.5 wait.h ):
>>
>>#define __wait_event_interruptible(wq, condition, ret)          \
>>do {                                                                    \
>>        wait_queue_t __wait;                                     \
>>        init_waitqueue_entry(&__wait, current);           \
>>                                                                        \
>>        add_wait_queue(&wq, &__wait);                   \
>>        for (;;) {                                                      \
>>                set_current_state(TASK_INTERRUPTIBLE);    \
>>                if (condition)                                          \
>>                        break;
>>........................................
>>
>>Is it possible that scheduling happen after set_current_state() but before
>>checking the condition ?
>>If yes - even if we will have condition==TRUE by this moment - the 
>>scheduler
>>will make the process to sleep anyway , right ?
>
>Yes, but since the condition would then have changed after we were put into 
>the wait queue, they would have woken up the queue and we should be woken 
>up again.
>
>--
>Robert Hancock      Saskatoon, SK, Canada
>To email, remove "nospam" from hancockr@nospamshaw.ca
>Home Page: http://www.roberthancock.com/
>


And what if the condition have changed after we have checked it in 
wait_event() but
before calling __wait_event() and before putting the process into the wait 
queue ?
The process could not be woken up "in advance" , right ?


#define wait_event(wq, condition)        \
do {                                                   \
        if (condition)                                \
                break;                                 \
   /* and here we have condition changed  ???? */
        __wait_event(wq, condition);        \
} while (0)


Regards
Alexey Shinkin

_________________________________________________________________
Don't just search. Find. Check out the new MSN Search! 
http://search.msn.com/


  reply	other threads:[~2005-12-23  0:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5mIFB-6PS-33@gated-at.bofh.it>
2005-12-23  0:16 ` Robert Hancock
2005-12-23  0:51   ` Alexey Shinkin [this message]
2005-12-23  1:10     ` Steven Rostedt
2005-12-23  1:46       ` Alexey Shinkin
2005-12-23 20:48         ` Steven Rostedt
2005-12-23  0:04 Alexey Shinkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BAY16-F8E0161EA0C4B79180F698AF330@phx.gbl \
    --to=alexshinkin@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®