Re: [PATCH] HP Mobile data protection system driver with interrupt handling

["Burman Yan" <yan_952@hotmail.com>]

>From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
>To: "Burman Yan" <yan_952@hotmail.com>
>CC: akpm@osdl.org, linux-kernel@vger.kernel.org, khali@linux-fr.org
>Subject: Re: [PATCH] HP Mobile data protection system driver with interrupt 
>handling
>Date: Tue, 7 Nov 2006 15:37:51 -0500
>
>On 11/7/06, Burman Yan <yan_952@hotmail.com> wrote:
>>
>> >From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
>> >To: "Andrew Morton" <akpm@osdl.org>
>> >CC: "Burman Yan" <yan_952@hotmail.com>, linux-kernel@vger.kernel.org, 
>>"Jean
>> >Delvare" <khali@linux-fr.org>
>> >Subject: Re: [PATCH] HP Mobile data protection system driver with 
>>interrupt
>> >handling
>> >Date: Mon, 6 Nov 2006 17:18:53 -0500
>> >
>> >On 11/6/06, Andrew Morton <akpm@osdl.org> wrote:
>> >>On Fri, 03 Nov 2006 18:33:31 +0200
>> >>"Burman Yan" <yan_952@hotmail.com> wrote:
>> >> > +
>> >> > +static unsigned int mouse = 0;
>> >>
>> >>The `= 0' is unneeded.
>> >>
>> >> > +module_param(mouse, bool, S_IRUGO);
>> >> > +MODULE_PARM_DESC(mouse, "Enable the input class device on module
>> >>load");
>> >
>> >Does the parameter have to be called "mouse"? I'd rename it to "input"
>> >and drop the work "class" from parameter description.
>>
>>Dropping the "class" seems logical, but calling the parameter input
>>seems confusing to me - to a user that doesn't want to read too much
>>manual/code and just wants to play around with the device (I do that
>>sometimes)
>>mouse sounds more reasonable to me.
>>
>
>Except that the device is more similar to a joystick than a mouse...

Agreed - joystick it is.

>
>--
>Dmitry

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/