From: "Burman Yan" <yan_952@hotmail.com>
To: pavel@ucw.cz
Cc: kronos.it@gmail.com, linux-kernel@vger.kernel.org
Subject: RE: HP disk protection Re: Remn Yan <yan_952@hotmail.com> ha scritto:
Date: Sat, 14 Oct 2006 13:30:10 +0200 [thread overview]
Message-ID: <BAY20-F2629AFC1128150E2482D6D80B0@phx.gbl> (raw)
In-Reply-To: <20061014082608.GA3851@elf.ucw.cz>
>From: Pavel Machek <pavel@ucw.cz>
>To: Burman Yan <yan_952@hotmail.com>
>CC: kronos.it@gmail.com, linux-kernel@vger.kernel.org
>Subject: HP disk protection Re: Remn Yan <yan_952@hotmail.com> ha scritto:
>Date: Sat, 14 Oct 2006 10:26:08 +0200
>
>On Fri 2006-10-13 20:32:48, Burman Yan wrote:
> > >From: Luca Tettamanti <kronos.it@gmail.com>
>
> > >Burman Yan <yan_952@hotmail.com> ha scritto:
> > >> I would like to hear your remarks on this version.
> > >
> > >> +static ssize_t mdps_calibrate_store(struct device *dev,
> > >> + struct device_attribute *attr, const char *buf,
> > >size_t count)
> > >> +{
> > >> + mdps_calibrate_mouse();
> > >> + return count;
> > >> +}
> > >
> > >No locking here?
> >
> > I don't want to lock it here, since the mouse polling kthread is heavy
>as
> > it is.
>
> > I'd rather report a wrong value of mouse position while recalibrating.
> > The way I see it, if you're recalibrating your mouse, chances are you're
> > not playing at the same precise millisecond. In my opinion it's worth
>more
> > battery life.
>
>Hmm, and are you sure it can't oops or something?
Well, other than in calibrate, I use it only in one other place - the mouse
polling kthread
(mdps_mouse_kthread). In there it's used to calculate the absolute location
of the "mouse".
At most I will get a value that doesn not correspond to the current
position.
This means that the mouse pointer will perhaps jump, since the x calibration
value has
updated and y calibration has not yet.
Yan
_________________________________________________________________
FREE pop-up blocking with the new MSN Toolbar - get it now!
http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/
prev parent reply other threads:[~2006-10-14 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 13:10 [PATCH] HP mobile data protection system driver take 2 Burman Yan
2006-10-13 14:48 ` Pavel Machek
2006-10-13 15:15 ` Burman Yan
2006-10-13 16:58 ` Remn Yan <yan_952@hotmail.com> ha scritto: Luca Tettamanti
2006-10-13 18:32 ` Burman Yan
2006-10-14 8:26 ` HP disk protection " Pavel Machek
2006-10-14 11:30 ` Burman Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAY20-F2629AFC1128150E2482D6D80B0@phx.gbl \
--to=yan_952@hotmail.com \
--cc=kronos.it@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®