From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E87F218EA8 for ; Fri, 26 Sep 2025 02:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758855580; cv=none; b=tcec48O5jO1nt5bsn88IFa2rSggrwM/SnAXbVEipi/tVroXOxud/xFszYX9A46i/MDfYQuEx1qVroJamkUcj8vICvo8kLf/wBckGAYf81pDh43HeqWIRnVUpdA9MF8bZzWwqXpA4dlmuh7EajTnUosZ/nAPy7zyVc5Zgd5LXOHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758855580; c=relaxed/simple; bh=l0ECngto9cM+qQ8jmcCUSAhzMScieKqkggBmP+VLjPI=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=mrbMZl7vDmGZfb2VOdpiOAhNVqsUCB02qQi439z2djIN9lzZZ959gEpkUXqTyxrgxN1prkESiy8ocMRpQxM6cd8ybigKTIQHl9yUpl7SJIKz3nICY2QWxqWZNsznUbYcwIsWmbgEJz6E4wro6MEi08BcadZoQ82y8jfsJ45Vlus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kYMEIaL/; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kYMEIaL/" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-267facf9b58so12945205ad.2 for ; Thu, 25 Sep 2025 19:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758855578; x=1759460378; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=9DFZaTqWY2S2tGyXXJLRz+UlH7utbYQxFHAmg/aDwJo=; b=kYMEIaL/xFdW7ByzdPAGM19uPyr2VedoOgQpGEzFni7j0kw1S053MImDWJoRELagCu 2IHQulbaeQ7yCnPNtDiHVLoxGG0TyC83FpLaqroyL+hQ7J/fNkL+41jmqqWUbCSLkWNr ErQ+zMKtvBjorZVuisGz++sA2E5TMeHBVyQ9xxUEHh1jLDqAaEJvoOdLg3oInoOlfAvs yyYTTXVsgmdGoSxwp/pr7BkxfffUBL/Quj97yWkfrla2KSZXs+cMMKNMmDufshZzcyep ELIlh/sGq9ZwMj6gsAOXeFrSZFLqiu/2tUdL+p82jh4LvMbfadnBSXOgUdcOGq17aYN+ 3B9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758855578; x=1759460378; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9DFZaTqWY2S2tGyXXJLRz+UlH7utbYQxFHAmg/aDwJo=; b=lvFHdmkki7wQlF0WfspkHSn/ppznTD8vUCw03xQLT6YPrXUR5OL+MKYe/bRUprVMEg VPFBwjA+RzUux2WyTCLSvga0ophIadivd/qGoJ07GX7Kbom6jYcviSflqxJY1bMfOb4F dj1utU84sGJkns1+tsHY/5Q9hHIZY79nc6Ts4mLW838LIsRnAcYlc/uNQbeh6ahcpGUs XLe4jngZsohJwwBg3wK6Z0eEOFF3LcKJGLb8EqFQEUL/wqmmqr05pNSOpqTHRrIqcGKj Xl5V5PDqp8VE0AkU2DLQagTwOVdWIPraGm5/BYI8lXZRlZGGKNQ+56n5O0OPLYhP8Wyt 5Ipg== X-Forwarded-Encrypted: i=1; AJvYcCXULHOK3k7JMlSP1ZwtQyZxoCfBQmdWarrtKpO0ngpzB9NQyIjOEFXcCs4uMI5XWJp3if2CZ4aR3MG5JhE=@vger.kernel.org X-Gm-Message-State: AOJu0YxlsW+EMHFPDSRnNH/1IWTB/asvAtjaJsgi3lM637Hi1ETHusSN hqzF7QgfInaJank1zqbnb/H6kIkcdQ4NhRcOQfo5CpYbEUSn6a856shC X-Gm-Gg: ASbGncux78Pur7DPp0Pm2F783jZ1Y61+cgULxRp+sKNGvHA6dOVrhhdvHT+c5bkR2EJ u07t2J5begNrMjbMk/WIJBbNttTAh7b59bafg01yT34BSOVpdvaB5GwR86n7+Xe61BsJB+9JGxq UtOEBxB4j4RMPEQyoeKiMMvduZPkpoJ2fHqSA3jAK1yACCYzEpSNffRSqIOssW/VrenI5WSO65e zDP75wHO2RVZ5L/Lrnn2Zu2hkcGuaLtXfnc57Qhg5SNenMTKGEYZH5b2Z7BORhe7C5nr4HP1BNf Qu8c/aw2i8A970KQfs4E+cfU7jMnYPuc26wbyAfNKE2Hq8GyOM28hn4H5aBGzZ2BYXSi8lDCguM 46QqUoOiPXnK3zS5Fnh0S3mUjgTBbAFHhfg== X-Google-Smtp-Source: AGHT+IF1KXe4IB93OQXtPcbKbci9ToFOHTHIp6Wzd2jpuNLiQ0xSjXqxp5GIX7bPJ7vagp05lKkQwQ== X-Received: by 2002:a17:903:4b04:b0:271:479d:3de2 with SMTP id d9443c01a7336-27ed4a1a2cdmr53853935ad.13.1758855578412; Thu, 25 Sep 2025 19:59:38 -0700 (PDT) Received: from ehlo.thunderbird.net ([2804:18:161:d250:a5b8:b662:f3c3:afe5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3341bd90587sm7255414a91.6.2025.09.25.19.59.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Sep 2025 19:59:38 -0700 (PDT) Date: Thu, 25 Sep 2025 23:19:09 -0300 From: =?ISO-8859-1?Q?Eric_Gon=E7alves?= To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] arm64: dts: qcom: r0q: enable max77705 PMIC User-Agent: Thunderbird for Android In-Reply-To: <53b1a622-3afc-4fd9-98b1-3c166f563ad0@oss.qualcomm.com> References: <20250920014637.38175-1-ghatto404@gmail.com> <20250920014637.38175-4-ghatto404@gmail.com> <53b1a622-3afc-4fd9-98b1-3c166f563ad0@oss.qualcomm.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On September 25, 2025 10:06:53 AM GMT-03:00, Konrad Dybcio wrote: >On 9/20/25 3:46 AM, Eric Gon=C3=A7alves wrote: >> The Samsung Galaxy S22 uses max77705 as its charger, fuelgauge and hapt= ic >> PMIC, enable the fuelgauge and charger for now=2E >>=20 >> Signed-off-by: Eric Gon=C3=A7alves >> --- > >[=2E=2E=2E] > >> +&i2c5 { >> + status =3D "okay"; >> + >> + max77705_charger: charger@69 { >> + compatible =3D "maxim,max77705-charger"; >> + reg =3D <0x69>; > >Please use tabs consistently Sure > >> + monitored-battery =3D <&battery>; >> + interrupt-parent =3D <&tlmm>; >> + interrupts =3D <5 IRQ_TYPE_LEVEL_LOW>; > >interrupts-extended =3D <&tlmm 5 IRQ=2E=2E=2E>, here and below why extended? > >> + }; >> + >> + fuel-gauge@36 { >> + reg =3D <0x36>; > >sorting by unit address is welcome Sure > >> + compatible =3D "maxim,max77705-battery"; >> + power-supplies =3D <&max77705_charger>; >> + interrupt-parent =3D <&tlmm>; >> + interrupts =3D <5 IRQ_TYPE_LEVEL_LOW>; >> + }; > >These nodes should be children of "maxim,max77705" >(see drivers/mfd/max77705=2Ec) What do you mean by this? I looked at the driver,=20 should I add the pmic@66 node and put the units inside of it? Because starqltechn doesn't do that and places them outside=2E Also, by adding the pmic@66 node it expects to have led/haptics nodes as well=2E > >Konrad