From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752677Ab1LSLRl (ORCPT ); Mon, 19 Dec 2011 06:17:41 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:35638 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408Ab1LSLRi convert rfc822-to-8bit (ORCPT ); Mon, 19 Dec 2011 06:17:38 -0500 References: <4EEDF6B1.7050206@tao.ma> <1324218278-2460-1-git-send-email-tm@tao.ma> In-Reply-To: <1324218278-2460-1-git-send-email-tm@tao.ma> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=us-ascii Message-Id: Content-Transfer-Encoding: 8BIT Cc: "linux-ext4@vger.kernel.org" , "adilger@dilger.ca" , "tytso@mit.edu" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" From: Andreas Dilger Subject: Re: [PATCH V3 01/21] ext4: Move extra inode read to a new function. Date: Mon, 19 Dec 2011 09:32:41 +0100 To: Tao Ma X-Mailer: iPhone Mail (9A405) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2011-12-18, at 15:24, Tao Ma wrote: > From: Tao Ma > > Currently, in ext4_iget we do a simple check to see whether > there does exist some information starting from the end > of i_extra_size. With inline data added, this procedure > is more complicated. So move it to a new function named > ext4_iget_extra_inode. > > + } else > + ext4_iget_extra_inode(inode, raw_inode, ei); > } else (style) if one half of an if-else uses braces then the other half should as well. Cheers, Andreas