From: Marcel Holtmann <marcel@holtmann.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ming Lei <ming.lei@canonical.com>, Pavel Machek <pavel@ucw.cz>,
"John W. Linville" <linville@tuxdriver.com>,
Grazvydas Ignotas <notasas@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Kalle Valo <kvalo@adurom.com>, Sebastian Reichel <sre@ring0.de>,
David Gnedt <david.gnedt@davizone.at>
Subject: Re: wl1251: NVS firmware data
Date: Tue, 9 Dec 2014 06:25:59 +0100 [thread overview]
Message-ID: <BB715185-F9EC-4FE6-8F23-79F47CE5BE04@holtmann.org> (raw)
In-Reply-To: <201412090027.46485@pali>
Hi Pali,
>> Use your own custom usermode helper for stuff like this, not
>> the firmware interface. But use a binary sysfs file if you
>> want, that seems to make sense for it...
>>
>> greg k-h
>
> Patch for telling permanent mac address from userspace via sysfs
> file was rejected for inclusion into mainline kernel.
>
> So I do not think that now maintainers of network subsystem allow
> it for nvs data...
>
> https://lkml.org/lkml/2013/12/8/35
this magic sysfs that has to be written to at the right time of the boot process to make this all work is something that will not work. I does not work for WiFi and it does not work for Bluetooth. Seems the discussion come full circle now and we are back to square one.
The problem is that either the driver does not register the device with mac80211 until it gets the MAC address provided by userspace or mac80211 should get an unconfigured state. The unconfigured state is something telling userspace that the device is present, but needs a few extra configuration information before it can become useful.
For Bluetooth, I went the later route. Mainly because the missing address is such a generic problem that solving it in the core makes a lot more sense. The driver just tells the core that it has no address for this device and provides a custom callback to configure the address when provided. After that everything resumes as normal.
However userspace gets informed when an unconfigured device gets added and at boot it can just query the list of unconfigured devices, or at runtime wait to be told there is a new unconfigured device that needs its attention. And then just provide the information. Once all information are present, the devices disappears as unconfigured and shows up as configured device ready for normal operation.
https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc/mgmt-api.txt#n2006
http://permalink.gmane.org/gmane.linux.bluez.kernel/50716
Can something similar be added to cfg80211 + nl80211. It bet it can, but that is up to Johannes to decide and someone to actually do the work and implement it.
Regards
Marcel
next prev parent reply other threads:[~2014-12-09 5:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 14:06 Pali Rohár
2014-11-27 14:21 ` Ming Lei
2014-11-27 14:43 ` Pali Rohár
2014-11-27 15:13 ` Ming Lei
2014-12-06 13:00 ` Pali Rohár
2014-11-27 15:14 ` Greg Kroah-Hartman
2014-11-27 15:24 ` Pali Rohár
2014-11-27 15:34 ` Ming Lei
2014-11-27 15:16 ` Greg Kroah-Hartman
2014-11-27 15:22 ` Pali Rohár
2014-11-27 15:58 ` Greg Kroah-Hartman
2014-12-06 12:49 ` Pavel Machek
2014-12-06 13:02 ` Pali Rohár
2014-12-08 15:18 ` Ming Lei
2014-12-08 15:22 ` Pali Rohár
2014-12-08 15:35 ` Ming Lei
2014-12-08 16:37 ` Greg Kroah-Hartman
2014-12-08 16:47 ` Pali Rohár
2014-12-08 17:05 ` Marcel Holtmann
2014-12-08 17:11 ` Pali Rohár
2014-12-08 18:50 ` Marcel Holtmann
2014-12-08 19:15 ` Pali Rohár
2014-12-08 19:26 ` Dan Williams
2014-12-08 19:36 ` Pali Rohár
2014-12-08 19:46 ` Marcel Holtmann
2014-12-08 19:56 ` Pali Rohár
2014-12-08 22:51 ` Dan Williams
2014-12-08 23:23 ` Pali Rohár
2014-12-08 23:42 ` Dan Williams
2014-12-08 23:52 ` Pali Rohár
2014-12-08 19:42 ` Ivaylo Dimitrov
2014-12-08 22:41 ` Dan Williams
2014-12-09 5:10 ` Marcel Holtmann
2014-12-08 19:41 ` Marcel Holtmann
2014-12-08 19:52 ` Pali Rohár
2014-12-08 21:00 ` Greg Kroah-Hartman
2014-12-08 21:08 ` Pali Rohár
2014-12-08 20:57 ` Greg Kroah-Hartman
2014-12-08 21:11 ` Pali Rohár
2014-12-08 23:27 ` Pali Rohár
2014-12-09 5:25 ` Marcel Holtmann [this message]
2014-12-09 0:48 ` Ming Lei
2014-12-09 4:08 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BB715185-F9EC-4FE6-8F23-79F47CE5BE04@holtmann.org \
--to=marcel@holtmann.org \
--cc=aaro.koskinen@iki.fi \
--cc=david.gnedt@davizone.at \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=kvalo@adurom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@ring0.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®