From: Marcel Holtmann <marcel@holtmann.org>
To: Howard Chung <howardchung@google.com>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>,
ChromeOS Bluetooth Upstreaming
<chromeos-bluetooth-upstreaming@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Johan Hedberg <johan.hedberg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [Bluez PATCH v1] Bluetooth: L2CAP: handle l2cap config request during open state
Date: Wed, 11 Mar 2020 15:50:56 +0100 [thread overview]
Message-ID: <BBDABF4D-E4CC-49D7-ADCF-6913B2DE9FF0@holtmann.org> (raw)
In-Reply-To: <20200310180642.Bluez.v1.1.I50b301a0464eb68e3d62721bf59e11ed2617c415@changeid>
Hi Howard,
> According to Core Spec Version 5.2 | Vol 3, Part A 6.1.5,
> the incoming L2CAP_ConfigReq should be handled during
> OPEN state.
>
> Signed-off-by: Howard Chung <howardchung@google.com>
>
> ---
>
> net/bluetooth/l2cap_core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index 697c0f7f2c1a..5e6e35ab44dd 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -4300,7 +4300,8 @@ static inline int l2cap_config_req(struct l2cap_conn *conn,
> return 0;
> }
>
> - if (chan->state != BT_CONFIG && chan->state != BT_CONNECT2) {
> + if (chan->state != BT_CONFIG && chan->state != BT_CONNECT2 &&
> + chan->state != BT_CONNECTED) {
> cmd_reject_invalid_cid(conn, cmd->ident, chan->scid,
> chan->dcid);
> goto unlock;
Any chance you can add a btmon trace excerpt for this to the commit message. It would be good to have the before and after here included.
Regards
Marcel
next prev parent reply other threads:[~2020-03-11 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 10:08 Howard Chung
2020-03-11 14:50 ` Marcel Holtmann [this message]
2020-03-11 14:50 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BBDABF4D-E4CC-49D7-ADCF-6913B2DE9FF0@holtmann.org \
--to=marcel@holtmann.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=howardchung@google.com \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®