From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751503AbcFCFq4 (ORCPT ); Fri, 3 Jun 2016 01:46:56 -0400 Received: from mga09.intel.com ([134.134.136.24]:50980 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbcFCFqy convert rfc822-to-8bit (ORCPT ); Fri, 3 Jun 2016 01:46:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,410,1459839600"; d="scan'208";a="820772003" From: "Li, Yong B" To: Tony Lindgren , Robert Nelson CC: Benoit Cousson , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , Russell King , "linux-omap@vger.kernel.org" , devicetree , "linux-arm-kernel@lists.infradead.org" , linux kernel , "sdliyong@gmail.com" Subject: RE: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry Thread-Topic: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry Thread-Index: AQHRvPVJp7hXljmlbUSg0QniPuEh3Z/V62uAgAABzICAAAL2gIABTEnQ Date: Fri, 3 Jun 2016 05:46:50 +0000 Message-ID: References: <1464853310-8738-1-git-send-email-yong.b.li@intel.com> <20160602173932.GF5995@atomide.com> <20160602175635.GG5995@atomide.com> In-Reply-To: <20160602175635.GG5995@atomide.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGRkNDcxN2QtYThiOS00ZjJmLWI5NzktNmNhNzVkNTQ0NjAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkY4T0dScUJoc3k0THdZaitvWEpyRXp1eGtqXC9IaHpBUlRuUU96aUpkaXk0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tony, I can submit a V2 version about the "disabled", or just drop this patch? Thanks, Yong -----Original Message----- From: Tony Lindgren [mailto:tony@atomide.com] Sent: Friday, June 3, 2016 1:57 AM To: Robert Nelson Cc: Li, Yong B ; Benoit Cousson ; Rob Herring ; Pawel Moll ; Mark Rutland ; Ian Campbell ; Kumar Gala ; Russell King ; linux-omap@vger.kernel.org; devicetree ; linux-arm-kernel@lists.infradead.org; linux kernel ; sdliyong@gmail.com Subject: Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry * Robert Nelson [160602 10:48]: > On Thu, Jun 2, 2016 at 12:39 PM, Tony Lindgren wrote: > > > > * Robert Nelson [160602 10:39]: > > > On Thu, Jun 2, 2016 at 2:41 AM, Yong Li wrote: > > > > > > > From: Yong Li > > > > > > > > Without this patch, I2C-1 is missing on beaglebone black boards > > > > > > > > Signed-off-by: Yong Li > > > > --- > > > > arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > > > > > > > > > > This is also 'common' for the white/green, if your really going to > > > push this, please add it to: > > > > > > am335x-bone-common.dtsi > > > > But isn't this exposed on the cape pins? So the use can be whatever > > for these pins? > > That is correct, "i2c1" is on the cape connector, with no primary > function defined. > > Currently on mainline, the board and cape eeprom i2c bus's are enabled. > > i2c0 = board eeprom > i2c2 = 'cape' eeprom > > personally, nak by me to add i2c1 by default, should use overlay's to enable it. Yes sounds like the best we can do is define it but set it with status = "disabled" for now. Regards, Tony