From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A7B11C5D44 for ; Sun, 3 May 2026 12:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777810027; cv=none; b=FbtsjittE6pmfqTZgRwmsH96GgG9fz+3/Hpy87q4BJRO/S4/iJivHHGvptnsZgqR6ixi9CfdwAWemG0ahxw3m8ZwI3p5whsh6Bt5E/wsMDDeJZYllZVz7qzwqgCwZCAoeEddi3eHxMe5/DSOdaqEG25j5H7qrnMsG3HC4Fhw7uA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777810027; c=relaxed/simple; bh=ws38jNJ/EKJMzjgt5yTRqqlpclmC8suspuO9Lro4JNI=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=kQvTThi/diavaBwk+rKPlCgJ8N2hNVo63NoXzlkzIgUtR8OdynSt3fSEN+7u34tchZ9RYj7e2oTN3P+ByPmmkPOfvfWtzjx0NPJyQathqBjrUKaJhUqZZgCYX5sZsYuaH8ErPOyeYMbgofOvV2nKZqgerT7Xid4irlbpLFvjFU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A70E2Phe; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A70E2Phe" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c80170db7d6so178844a12.0 for ; Sun, 03 May 2026 05:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777810026; x=1778414826; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=dXVoVASb/STmIjlJBKGmGSoe2gLnIU28O+1SSlhiQLk=; b=A70E2PheC13C7yYL3ARtATKs1wevg2nxBRc5YT3VEHW3bQlvg36ocAnHLTu6fXl8BE j3KN1JQoQUTe1ETctvp2d5vFUJ+38BdZoYz74Oa3Hir5o1QOyF1UgbrEe2UDUmcc+jKZ nSAITswfWPVQu119pa1rbFhTnDwjrwY1wumH5xcpnK+/bqrY3kHwKRSJGZidxATK9KiT QgN+JADCysLnFo/q9Dfdt7ElFWkkHH9rm94J4wD006OZbKWSbBav5/hMJE352WUIvdD/ xApCNowTaWNey9jal1aOW66fQybvhtNM6VMpnJ1Ndv50OzFbQHRoijCleNfd9XHVgfGf Ju3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777810026; x=1778414826; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dXVoVASb/STmIjlJBKGmGSoe2gLnIU28O+1SSlhiQLk=; b=jqCvUkWuKB3o1JuADGwMZN9NKdMKIajQL/mdT2UTMQo8rQV1JOZohb4hHAvBCqsAr4 Se61yQ2IwsH80e0LtZA1uQJ02iWAb/1nrf6xBCLgoAFRObA2qHA+H8/k8HkT41RD5h/p Ni+k+vNJCH+KaVs4YdewRt+PghinOr6L1TnDQBbRmVe/JOjCyFj5tMYwlOpsLazPdJA+ SkDhJd8PU7aM1mxV10GtvQ33QvcgzG3Imk7N/UnbhUU6S5yjf2EsfGYAsGffEPuDg9SR KTXSPHsVw1SwRlC9Ai4yxfJsfVV3TacDRSESnjQFQErtkx8ab7gvfqLJOKMZq00glUC9 mRfQ== X-Forwarded-Encrypted: i=1; AFNElJ+z28Hf0kvFrHNf6qrsSyVu4MqMdv7NtAvP7TAsHgAJruX/YwaE7ZW99jBpqGSNbUyQl9Irzcvd/Fb8nAI=@vger.kernel.org X-Gm-Message-State: AOJu0YyAXaeEUbVpXYcd5N7+b/KXQKYXdT5ibd9/LTJT4jXrNGqp+9wj i1x/kY2hgEcZvuj0hUu8MXBhiNht1m8SwsTr3czVh3BgaP9e6/6iK5Gq X-Gm-Gg: AeBDieupZpLJI5lrz5mjd8lYE8grti3t2zkka2K5BsTp3A/qYAF/Uf5xhDhlJwSACuI mO0+85GZtqAbuPNOZzQRhY9if8OA3pSESttw09NbdWA/mepkGjsLJgr+WZ5vn5jbzfvn0xjdzZR +YWi/v5kIQLWzH4l6T8QAYcm5nkOuDEcba5VYKXIIsZN1B3uCU4utK/nHMdayoLcXV1NvqkdCYu nSdZrXmeZFT7xvq5J7EB67X7YpMQes+B6l4LmrBU/hiOMPT8aa7PN426yAqc419fwziOC/vDn1a /HiHodaHac3lPvTu7HOzmIwptvlgsxQWG7USDHrz5zXTDJW20YGADnegqMYGdOsj7WxATduHRdt qcUQgFMO7rJ4JRhVF8tVmC9Vi3WL32YaeFdIMi0wddBOa9srNeibZ76I2KhADxNm6UXG194ReVM TEYGrd/xgmoASIVRFAjQPMAliG06jrLWsk3AaPpZRgOx+sulMt953luWY= X-Received: by 2002:a17:903:22c1:b0:2b9:493f:61bc with SMTP id d9443c01a7336-2b9f2829c33mr57360035ad.38.1777810025738; Sun, 03 May 2026 05:07:05 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:c032:ba9d:4953:28:24e7:1e48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3afdasm74320135ad.62.2026.05.03.05.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 May 2026 05:07:05 -0700 (PDT) Date: Sun, 03 May 2026 17:36:55 +0530 From: Sanjay Chitroda To: Andy Shevchenko , Jonathan Cameron CC: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, mingo@kernel.org, christophe.jaillet@wanadoo.fr, nabijaczleweli@nabijaczleweli.xyz, kees@kernel.org, kyungmin.park@samsung.com, k.wrona@samsung.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 5/9] iio: ssp_sensors: use local struct device User-Agent: Thunderbird for Android In-Reply-To: References: <20260426091710.3722035-1-sanjayembedded@gmail.com> <20260426091710.3722035-6-sanjayembedded@gmail.com> <20260426151651.48a690c9@jic23-huawei> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 27 April 2026 1:39:32=E2=80=AFpm IST, Andy Shevchenko wrote: >On Sun, Apr 26, 2026 at 03:16:51PM +0100, Jonathan Cameron wrote: >> On Sun, 26 Apr 2026 14:47:06 +0530 >> Sanjay Chitroda wrote: > >=2E=2E=2E > >> > Introduce a struct device *dev derived from &spi->dev to improve >> > readability and reorder variable(s) to follow reversed xmas tree styl= e=2E >> It's really minor reordering but generally I'd not do that in a patch >> that does anything else=2E So here I'd have put the new variables >> in as close to correct location as possible, then followed with >> a reorder if it was worth the churn that results=2E I'm not sure it is >> in this particular case=2E > >+1=2E And ideally that 'i' has to be converted to unsigned type=2E Thank you Jonathan and Andy for review=2E I will keep this change specific to dev and drop redundant probe failure l= og=2E Also, as a follow-up change will do re-order variables and have unsigned t= ype change=2E >