mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aleksandar Markovic <Aleksandar.Markovic@mips.com>
To: Joe Perches <joe@perches.com>,
	Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Cc: Miodrag Dinic <Miodrag.Dinic@mips.com>,
	Goran Ferenc <Goran.Ferenc@mips.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Douglas Leung" <Douglas.Leung@mips.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	James Hogan <James.Hogan@mips.com>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	Miodrag Dinic <miodrag.dinic@imgtec.com>,
	Paul Burton <Paul.Burton@mips.com>,
	"Petar Jovanovic" <Petar.Jovanovic@mips.com>,
	Raghu Gandham <Raghu.Gandham@mips.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	"Thomas Gleixner" <tglx@linutronix.de>
Subject: RE: [PATCH v7 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC driver
Date: Fri, 3 Nov 2017 14:10:13 +0000	[thread overview]
Message-ID: <BD3A5F1946F2E540A31AF2CE969BAEEEC19BF3@MIPSMAIL01.mipstec.com> (raw)
In-Reply-To: <1509640479.31043.80.camel@perches.com>

> From: Joe Perches [joe@perches.com]
> ...
>On Thu, 2017-11-02 at 17:21 +0100, Aleksandar Markovic wrote:
> ...
>
> > Signed-off-by: Miodrag Dinic <miodrag.dinic@mips.com>
> > Signed-off-by: Goran Ferenc <goran.ferenc@mips.com>
> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
> > wq
> 
> vi much?
> 

:)

> > +/*
> > + * Driver for MIPS Goldfish Programmable Interrupt Controller.
> > + *
> > + * Author: Miodrag Dinic <miodrag.dinic@mips.com>
> > + *
> > + * This program is free software; you can redistribute       it and/or modify it
> > + * under  the terms of       the GNU General  Public License as published by the
> > + * Free Software Foundation;  either version 2 of the  License, or (at your
> > + * option) any later version.
> > + */
> 
> Odd mix of spaces and tabs
> 

Will be fixed in v8.

> It'd be good to add a #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #include so the pr_<level> output is prefixed appropriately.

Error and info messages will be completely revised in v8.

Thanks for the review!

Aleksandar

  reply	other threads:[~2017-11-03 14:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 16:21 [PATCH v7 0/5] MIPS: Add virtual Ranchu board as a generic-based board Aleksandar Markovic
2017-11-02 16:21 ` [PATCH v7 1/5] Documentation: Add device tree binding for Goldfish PIC driver Aleksandar Markovic
2017-11-02 16:21 ` [PATCH v7 2/5] irqchip/irq-goldfish-pic: Add " Aleksandar Markovic
2017-11-02 16:34   ` Joe Perches
2017-11-03 14:10     ` Aleksandar Markovic [this message]
2017-11-02 16:21 ` [PATCH v7 3/5] Documentation: Add device tree binding for Goldfish FB driver Aleksandar Markovic
2017-11-02 16:21 ` [PATCH v7 4/5] video: goldfishfb: Add support for device tree bindings Aleksandar Markovic
2017-11-02 16:21 ` [PATCH v7 5/5] MIPS: ranchu: Add Ranchu as a new generic-based board Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BD3A5F1946F2E540A31AF2CE969BAEEEC19BF3@MIPSMAIL01.mipstec.com \
    --to=aleksandar.markovic@mips.com \
    --cc=Douglas.Leung@mips.com \
    --cc=Goran.Ferenc@mips.com \
    --cc=James.Hogan@mips.com \
    --cc=Miodrag.Dinic@mips.com \
    --cc=Paul.Burton@mips.com \
    --cc=Petar.Jovanovic@mips.com \
    --cc=Raghu.Gandham@mips.com \
    --cc=aleksandar.markovic@rt-rk.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason@lakedaemon.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=marc.zyngier@arm.com \
    --cc=mchehab@kernel.org \
    --cc=miodrag.dinic@imgtec.com \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®